Page MenuHomePhabricator

The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled
Closed, ResolvedPublic

Description

In the VisualEditor, click the ≡ icon and click "Options" to get to the meta / "Page options" dialog.
Here, the "Apply changes" button is always enabled. It should only be enabled if the user has made any changes in the dialog.

Event Timeline

matmarex created this task.Oct 23 2018, 4:44 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 23 2018, 4:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I would like to mentor this task in Google-Code-in-2018.

Change 470254 had a related patch set uploaded (by Flutterish; owner: Flutterish):
[mediawiki/extensions/VisualEditor@master] "Apply changes" is now only enabled after making changes

https://gerrit.wikimedia.org/r/470254

Change 470661 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Wait for each page to set up (especially 'category')

https://gerrit.wikimedia.org/r/470661

Change 470254 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: "Apply changes" is now only enabled after making changes

https://gerrit.wikimedia.org/r/470254

Change 470671 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Consider category sortkeys when checking for changes

https://gerrit.wikimedia.org/r/470671

https://gerrit.wikimedia.org/r/470661 fixes a pre-existing issue in the "Categories" page of the dialog that interferes with this new feature.

https://gerrit.wikimedia.org/r/470671 makes this work when updating category sortkeys (I forgot about them when reviewing the original patch, sorry).

Change 470671 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Consider category sortkeys when checking for changes

https://gerrit.wikimedia.org/r/470671

Change 470661 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Wait for each page to set up (especially 'category')

https://gerrit.wikimedia.org/r/470661

Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Joint with @matmarex for the extra fixes. :-)

matmarex closed this task as Resolved.Nov 2 2018, 12:03 AM