Page MenuHomePhabricator
Create Task
Maniphest T207735

Text editors should be focussed and scrollable in js
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Motivation
Right now, the non-js version contains scroll bars for the editors. The js-version does not. Currently, when you want to edit in an editor, you have to focus it first, and then use the up and down arrow keys to navigate further down.

Acceptance Criteria
[] If I click on "edit" for a paragraph, the text editor is automatically focussed.
[] If the text in the editor is longer than the text area field, the editor becomes scrollable

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Focus the visible editor onlymediawiki/extensions/TwoColConflictmaster+4 -2
Focussed and scrollable text editorsmediawiki/extensions/TwoColConflictmaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

• Lea_WMDE created this task.Oct 23 2018, 10:18 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptOct 23 2018, 10:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-10-23.Oct 23 2018, 1:17 PM
• Lea_WMDE set the point value for this task to 3.

It seems like right now some css hides the scrollbar. Undoing this should solve one of the acceptance criteria.

• Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Oct 23 2018, 1:18 PM
thiemowmde subscribed.Oct 23 2018, 1:28 PM

Quick investigation: An overflow: hidden causes the problem of not being able to scroll with two fingers or the mouse wheel. This must be removed.

In addition, I suggest to add this (but this can also be done as part of T207161, T207163, or T202060):

min-height: 4em;
resize: vertical;
Andrew-WMDE claimed this task.Oct 24 2018, 11:02 AM
gerritbot subscribed.Oct 24 2018, 11:04 AM

Change 469410 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Focussed and scrollable text editors

https://gerrit.wikimedia.org/r/469410

gerritbot added a project: Patch-For-Review.Oct 24 2018, 11:04 AM
Andrew-WMDE mentioned this in rESCCbd00667bf128: Focussed and scrollable text editors.Oct 24 2018, 11:05 AM
Andrew-WMDE mentioned this in rESCC326fcdb73d71: Focussed and scrollable text editors.Oct 24 2018, 11:32 AM
Andrew-WMDE moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-10-23 board.Oct 24 2018, 11:40 AM
Andrew-WMDE mentioned this in rESCC6c108bd4e0e9: Focussed and scrollable text editors.Oct 24 2018, 11:54 AM
gerritbot added a comment.Oct 26 2018, 11:32 AM

Change 469862 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Focus the visible editor only

https://gerrit.wikimedia.org/r/469862

thiemowmde mentioned this in rESCCbc9c4d392c28: Focus the visible editor only.Oct 26 2018, 11:34 AM
gerritbot added a comment.Oct 26 2018, 11:42 AM

Change 469410 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Focussed and scrollable text editors

https://gerrit.wikimedia.org/r/469410

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 26 2018, 12:00 PM
thiemowmde mentioned this in rESCC7bb14190273b: Focus the visible editor only.Oct 26 2018, 7:43 PM
WMDE-Fisch mentioned this in rESCC199488ae8301: Focus the visible editor only.Oct 28 2018, 5:08 PM
thiemowmde mentioned this in rESCCcb97b7fa101a: Focus the visible editor only.Oct 31 2018, 1:24 PM
thiemowmde mentioned this in rESCCf01758073046: Focus the visible editor only.Oct 31 2018, 1:27 PM
thiemowmde mentioned this in rESCC630685b930d6: Focus the visible editor only.Oct 31 2018, 2:00 PM
gerritbot added a comment.Oct 31 2018, 3:12 PM

Change 469862 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Focus the visible editor only

https://gerrit.wikimedia.org/r/469862

Andrew-WMDE moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-10-23 board.Oct 31 2018, 3:13 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.3; 2018-11-06); removed MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 31 2018, 4:00 PM
• Lea_WMDE closed this task as Resolved.Nov 1 2018, 10:47 AM
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-10-23 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits