Page MenuHomePhabricator

Text editors should be focussed and scrollable in js
Closed, ResolvedPublic3 Estimated Story Points

Description

Motivation
Right now, the non-js version contains scroll bars for the editors. The js-version does not. Currently, when you want to edit in an editor, you have to focus it first, and then use the up and down arrow keys to navigate further down.

Acceptance Criteria
[] If I click on "edit" for a paragraph, the text editor is automatically focussed.
[] If the text in the editor is longer than the text area field, the editor becomes scrollable

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_WMDE set the point value for this task to 3.

It seems like right now some css hides the scrollbar. Undoing this should solve one of the acceptance criteria.

Quick investigation: An overflow: hidden causes the problem of not being able to scroll with two fingers or the mouse wheel. This must be removed.

In addition, I suggest to add this (but this can also be done as part of T207161, T207163, or T202060):

min-height: 4em;
resize: vertical;

Change 469410 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Focussed and scrollable text editors

https://gerrit.wikimedia.org/r/469410

Change 469862 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Focus the visible editor only

https://gerrit.wikimedia.org/r/469862

Change 469410 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Focussed and scrollable text editors

https://gerrit.wikimedia.org/r/469410

Change 469862 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Focus the visible editor only

https://gerrit.wikimedia.org/r/469862

Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-10-23 board.