| • MichaelSchoenitzer_WMDE | |
| Oct 23 2018, 7:27 PM |
| F26749050: Bildschirmfoto zu 2018-10-23 21-22-22.png | |
| Oct 23 2018, 7:27 PM |
In the revision-slider each revision is shown as a grey bar. Not selected revisions are light grey while revisions within the selected range are darker gray. Revisions of a user that has been selected are also shown darker grey. These two grays are similar and easy to confuse.
In the following screenshot it might look like user "Aka" not only did the second-last edit and the one edit in the middle but also the three edits at the beginning:
Suggestions: change the colors to be more distinct.
Change 471537 had a related patch set uploaded (by Sherlock07; owner: Sherlock07):
[mediawiki/extensions/RevisionSlider@master] fixed bug:T207782
Change 471539 had a related patch set uploaded (by Tle; owner: Yash Khare):
[mediawiki/extensions/RevisionSlider@master] Changed the color to the darker shade of grey
Please do not claim tasks that already have someone working on it and a patch to review.
Please respect the "assignee" field. Thanks.
@Aklapper Could this be some new form of hostile bots? All the accounts (@Hkrishr @nandhinibalaji311 and @Yashk2000) have zero other activity here as well as zero edits on all wikis.
Change 472455 had a related patch set uploaded (by Vijay9908; owner: Vijay9908):
[mediawiki/extensions/RevisionSlider@master] "Bug: T207782 Color of selected revisions and color of highlightend users are easy to confuse fixed"
Change 471559 had a related patch set uploaded (by Lohitha; owner: Lohitha):
[mediawiki/extensions/RevisionSlider@master] Modified to a darker shade
Change 471537 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Sherlock07):
[mediawiki/extensions/RevisionSlider@master] Use darker gray for user highlighting
Namah Shivaya,
Today I tried my first project with django. I got alot of errors and I
tried fixing them but was not successful at the last step. I will fix it
tomorrow.
Regards
Nandhini Balaji
Note that there are already three patches linked from this task. (Please stick to the topic of the task when commenting on task - thanks!)
Marking as closed after the patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RevisionSlider/+/474410/ Thanks :)
Change 472455 abandoned by Aklapper:
"Bug: T207782 Color of selected revisions and color of highlightend users are easy to confuse fixed"
Reason:
Incorrect patch (one level too low in the folder hierarchy). Superseded by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RevisionSlider/ /474410/ hence abandoning.
Change 471537 abandoned by Aklapper:
Use darker gray for user highlighting
Reason:
Hi Sherlock07, thanks for your patch! We received several patches for this task and in the end https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RevisionSlider/ /474410/ was merged which fixes this problem. Hence I am abandoning this one.
Change 471559 abandoned by Aklapper:
Modified to a darker shade
Reason:
Hi Lohitha, thanks for your patch! We received several patches for this task and in the end https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RevisionSlider/ /474410/ was merged which fixes this problem. Hence I am abandoning this one.
Change 471539 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/RevisionSlider@master] Changed the color to the darker shade of grey
Reason:
The ticket T207782 received multiple competing patches. Only one could have been merged.