Page MenuHomePhabricator

Revisionslider does not open
Closed, InvalidPublic

Description

With my personal account revision slider does not open anymore on some pages. Clicking on the bar of revisionslider does not open it. There are no errors or warnings in the javascript console.
Any input on how to debug?

Peek 2018-10-23 21-32.gif (1,090×389 px, 78 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Does the same problem happen with URL parameter safemode=1?

how to approach to debug this like where to start with?
clearly, i see no problem in my PC and even tested in some of my friends laptops too.I see no issue.

Change 472648 had a related patch set uploaded (by Nithin999; owner: Nithin999):
[mediawiki/core@master] T207783 is fixed

https://gerrit.wikimedia.org/r/472648

Change 472648 abandoned by Aklapper:
T207783 is fixed

Reason:
Hi Nithin1999 and thanks for your patch!
Unfortunately this patch is for the wrong code repository. RevisionSlider is a separate extension. Its code does not live in the "mediawiki/core" repository. You need to provide a new patch against the correct repository; that's why I'm abandoning this patch here as it cannot be merged.

For any future patches, please follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines and add a meaningful commit message.

https://gerrit.wikimedia.org/r/472648

Resetting assignee as Nithin has not been active in the last days. Note that anyone (including Nithin, of course) is free and very welcome to work on this and improve Nithin's patch in Gerrit. Thanks :)

thiemowmde subscribed.

While I have seen the same behavior I was never able to reliably reproduce it. A hard refresh (shift+reload) always makes it disappear. It appears like it's connected to some ResourceLoader modules getting out of sync or something.

The linked patch https://gerrit.wikimedia.org/r/472648 is of no help, unfortunately. The best theory I have is that the codebase was partly outdated at this point in time and either an update or shift+reload would have fixed it.