Page MenuHomePhabricator
Create Task
Maniphest T207805

MFA: Port the references feature to webpack: Merge mobile.references and mobile.references.gateway
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Now mobile.startup has been ported to webpack we'll want to start thinking about how features are organised going forward. The mobile.references feature is loaded on startup by the Minerva skin and quite well contained so it makes sense to start with porting this feature first.

The references feature makes use of two modules:

  • mobile.references
  • mobile.references.gateway

Acceptance criteria

  • There is no or mobile.references.gateway modules -these are now part of mobile.startup ! yay! (Thus: the references code is loaded in the initial JS bundle for Minerva)
  • There is no mobile.references module -these are now part of mobile.startup ! yay! (Thus: the references code is loaded in the initial JS bundle for Minerva)
  • Reference feature is shipped inside mobile.startup
  • Tests for mobile.references.gateway can be run in headless mode.
  • Tests for ReferencesDrawer can be run in headless mode.
  • We have thought about how to organise "features" in Minerva.
  • mobile.references.images is merged with mobile.startup.images (no alias needed)
  • Minerva is retained in a mergeable state throughout the migration: This can be done in 3 patches. 1) making the move and making mobile.references symlink to mobile.startup 2) updating Minerva 3) removing the mobile.references symlink.
  • A good conversation has been had by all involved about how we plan to migrate other features e.g. search, watchstar and T208921 has been updated with any practical details.

Sign off steps

  • Progress is updated.
  • The watchstar (T208921) and/or search features makes sense to be ported next. Create/update cards.

Details

SubjectRepoBranchLines +/-
Organise src folder by featuremediawiki/extensions/MobileFrontendmaster+49 -46
Remove the mobile.references module now all references have been updatedmediawiki/extensions/MobileFrontendmaster+0 -8
Merge mobile.references into mobile.startupmediawiki/extensions/MobileFrontendmaster+266 -263
Update references to deprecated modulesmediawiki/skins/MinervaNeuemaster+5 -9
Merge mobile.references.gateway into mobile.startupmediawiki/extensions/MobileFrontendmaster+430 -426
mobile.references.images is merged into mobile.startup.imagesmediawiki/extensions/MobileFrontendmaster+2 -8
Update references to deprecated modulesmediawiki/extensions/MobileFrontendmaster+2 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson triaged this task as High priority.Oct 23 2018, 11:12 PM
Jdlrobson created this task.
Jdlrobson edited projects, added Web-Team-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Oct 23 2018, 11:15 PM
Jdlrobson updated the task description. (Show Details)Oct 23 2018, 11:21 PM
Jdlrobson updated the task description. (Show Details)Nov 6 2018, 6:38 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Nov 6 2018, 6:52 PM
Jdlrobson added subscribers: • nray, pmiazga, ovasileva, Stephen.Nov 6 2018, 9:18 PM

We did an async estimation : @pmiazga: 3, @Stephen: 8, @Jdlrobson: 5, @nray: 5
@ovasileva let's quikcly talk through this in prioritisation tomorrow.

Jdlrobson mentioned this in T208920: MFA: add tests for Drawer and CtaDrawer.Nov 7 2018, 12:47 AM
Jdlrobson mentioned this in T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack.Nov 7 2018, 12:52 AM
Jdlrobson updated the task description. (Show Details)Nov 7 2018, 12:55 AM
ovasileva set the point value for this task to 8.Nov 7 2018, 5:22 PM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.
Jdlrobson claimed this task.Nov 8 2018, 4:36 PM
Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
gerritbot subscribed.Nov 8 2018, 9:28 PM

Change 472571 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] mobile.references.images is merged into mobile.startup.images

https://gerrit.wikimedia.org/r/472571

gerritbot added a project: Patch-For-Review.Nov 8 2018, 9:28 PM

Change 472572 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Merge mobile.references.gateway into mobile.startup

https://gerrit.wikimedia.org/r/472572

gerritbot added a comment.Nov 8 2018, 9:31 PM

Change 472573 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Merge mobile.references into mobile.startup

https://gerrit.wikimedia.org/r/472573

gerritbot added a comment.Nov 8 2018, 9:36 PM

Change 472574 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Update references to deprecated modules

https://gerrit.wikimedia.org/r/472574

gerritbot added a comment.Nov 8 2018, 9:37 PM

Change 472575 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update references to deprecated modules

https://gerrit.wikimedia.org/r/472575

gerritbot added a comment.Nov 8 2018, 9:38 PM

Change 472576 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the mobile.references module now all references have been updated

https://gerrit.wikimedia.org/r/472576

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 8 2018, 9:38 PM
gerritbot added a comment.Nov 8 2018, 10:02 PM

Change 472575 abandoned by Jdlrobson:
Update references to deprecated modules

Reason:
Squashing into https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/ /472572/1

https://gerrit.wikimedia.org/r/472575

gerritbot added a comment.Nov 9 2018, 6:35 PM

Change 472571 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.references.images is merged into mobile.startup.images

https://gerrit.wikimedia.org/r/472571

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 9 2018, 7:00 PM
Jdlrobson updated the task description. (Show Details)Nov 13 2018, 6:41 PM

Merge mobile.references.gateway into mobile.startup is next up for review!

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 14 2018, 6:19 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 14 2018, 8:23 PM
• nray moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 14 2018, 10:32 PM
• nray moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 15 2018, 12:06 AM
• nray moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 15 2018, 1:21 AM

1 big patch merged! Still more AC to do so I'm moving to Needs More Work column

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 15 2018, 1:31 AM

https://gerrit.wikimedia.org/r/472574 and https://gerrit.wikimedia.org/r/472573 are now ready for review.

Jdlrobson updated the task description. (Show Details)Nov 15 2018, 1:32 AM
gerritbot added a comment.Nov 15 2018, 1:37 AM

Change 472572 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Merge mobile.references.gateway into mobile.startup

https://gerrit.wikimedia.org/r/472572

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 15 2018, 2:00 AM
gerritbot added a comment.Nov 16 2018, 6:12 PM

Change 472573 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Merge mobile.references into mobile.startup

https://gerrit.wikimedia.org/r/472573

gerritbot added a comment.Nov 16 2018, 6:15 PM

Change 472574 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update references to deprecated modules

https://gerrit.wikimedia.org/r/472574

Jdlrobson updated the task description. (Show Details)Nov 16 2018, 6:21 PM
Jdlrobson updated the task description. (Show Details)Nov 16 2018, 6:26 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application added a subscriber: • Gilles. · View Herald TranscriptNov 19 2018, 6:11 PM
Jdlrobson renamed this task from Port the references feature to webpack: Merge mobile.references and mobile.references.gateway to MFA: Port the references feature to webpack: Merge mobile.references and mobile.references.gateway.Nov 20 2018, 5:51 PM
Jdlrobson added a comment.Nov 20 2018, 10:34 PM

The last patch standing is https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/472576/
Once that's done I'll switch gears to conversation mode!

gerritbot added a comment.Nov 21 2018, 10:17 AM

Change 472576 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove the mobile.references module now all references have been updated

https://gerrit.wikimedia.org/r/472576

Jdrewniak updated the task description. (Show Details)Nov 21 2018, 2:37 PM
Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 21 2018, 5:56 PM
Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 26 2018, 7:41 PM
gerritbot added a comment.Nov 26 2018, 8:05 PM

Change 475828 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Organise src folder by feature

https://gerrit.wikimedia.org/r/475828

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 26 2018, 8:05 PM

We talked about this today. We felt that organising by feature sounds useful, however we believe when we start code splitting we may want to revisit this folder structure again.
The patch https://gerrit.wikimedia.org/r/475828 moves the references code into the references feature folder.

• Gilles unsubscribed.Nov 27 2018, 8:31 AM
Jdlrobson reassigned this task from Jdlrobson to • Niedzielski.Nov 27 2018, 6:13 PM

Stephen says he'll review this.

gerritbot added a comment.Nov 27 2018, 7:58 PM

Change 475828 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Organise src folder by feature

https://gerrit.wikimedia.org/r/475828

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 7:58 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 27 2018, 8:00 PM
• Niedzielski removed • Niedzielski as the assignee of this task.Nov 29 2018, 6:03 PM
• Niedzielski subscribed.
Jdlrobson updated the task description. (Show Details)Nov 29 2018, 7:04 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• Niedzielski claimed this task.Dec 3 2018, 6:04 PM
• Niedzielski closed this task as Resolved.Dec 3 2018, 8:56 PM

Looks good to me!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL