EG. wfDebugLog( __CLASS__ should instead log to a more generic log channel that we actually see in production, such as "Wikibase" (TBA actually make sure this is configured in prod).
The level should also be checked, perhaps we don't want to log debug level to logstash for example?
Maybe some of these log positions could also be removed?
Description
Details
Event Timeline
Change 474185 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Define a new 'Wikibase' log channel to use
Change 474187 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP DNM Consolidate logging
Change 475429 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in client
Change 474185 merged by jenkins-bot:
[operations/mediawiki-config@master] Define a new 'Wikibase' log channel to use
Mentioned in SAL (#wikimedia-operations) [2018-12-05T08:48:22Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T207850 Define a new Wikibase log channel to use (duration: 00m 47s)
Change 474187 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in client
Change 475429 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in lib
Change 477978 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Remove StubUserLang debug logging
Change 478193 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in Repo\UpdateRepo
Change 478196 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[operations/mediawiki-config@master] Remove the "wikibase-debug" log channel
Change 477978 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove StubUserLang debug logging
Change 478193 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in Repo\UpdateRepo
Change 478219 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in repo
Change 478196 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove the "wikibase-debug" log channel
Mentioned in SAL (#wikimedia-operations) [2018-12-10T12:13:24Z] <hoo@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Remove the "wikibase-debug" log channel (T207850) (duration: 00m 47s)
Change 478219 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PSR Logger instead of wfDebugLog in repo
$ grep -rnF 'wfLogWarning(' Wikibase WikibaseLexeme/ WikibaseQualityConstraints/ | wc -l 41 $ grep -rnF 'wfWarn(' Wikibase WikibaseLexeme/ WikibaseQualityConstraints/ | wc -l 22
Do we care about them in this context? wfLogWarning/ wfWarn work differently form wfDebugLog as they actually trigger a PHP error.