Maniphest T207855

QualityConstraints\Api\CheckConstraintsRdf is missing tests
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

There doesn't appear to be any tests relating to the CheckConstraintsRdf Action (not action api action).

We should have some sort of test coverage.

Details

	Subject	Repo	Branch	Lines +/-
	Add tests for CheckConstraintsRdf	mediawiki/extensions/WikibaseQualityConstraints	master	+235 -0

Customize query in gerrit

Event Timeline

Tarrow created this task.Oct 24 2018, 3:27 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 24 2018, 3:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Addshore renamed this task from QualityConstraints \Api\CheckConstraintsRdf is missing tests to QualityConstraints\Api\CheckConstraintsRdf is missing tests.Nov 6 2018, 11:44 AM

Addshore triaged this task as Low priority.

Addshore added projects: Test-Coverage, Wikibase-Quality-Constraints.

Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Addshore updated the task description. (Show Details)Nov 13 2018, 11:47 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 13 2018, 11:53 AM

Addshore updated the task description. (Show Details)Nov 13 2018, 2:23 PM

Addshore updated the task description. (Show Details)

Addshore set the point value for this task to 5.

Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore moved this task from incoming to in progress on the Wikidata board.Nov 13 2018, 3:34 PM

Michael claimed this task.Nov 19 2018, 2:24 PM

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 474911 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for CheckConstraintsRdf

https://gerrit.wikimedia.org/r/474911

gerritbot added a project: Patch-For-Review.Nov 20 2018, 1:42 PM

Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 21 2018, 11:14 AM

Change 474911 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for CheckConstraintsRdf

https://gerrit.wikimedia.org/r/474911

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 21 2018, 12:00 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 22 2018, 11:04 AM

Lydia_Pintscher closed this task as Resolved.Nov 26 2018, 1:56 PM

Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.