Page MenuHomePhabricator
Create Task
Maniphest T207930

Moving or deleting a translatable page on mediawiki.org triggers an error message
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

I was trying to move a translatable page from Growth/Community/How_to_work_with_newcomers_on_help_desk to Growth/Communities/How to work with newcomers on help desks using https://www.mediawiki.org/wiki/Special:MovePage/Growth/Community/How_to_work_with_newcomers_on_help_desk

Then I click on "Check if the move is possible", I'm getting the follwing error message:

PHP fatal error: Argument 1 passed to TranslateUtils::addWikiTextAsInterface() must be an instance of OutputPage, string given

Details

SubjectRepoBranchLines +/-
Fix fatal errors from b2586aemediawiki/extensions/Translatemaster+4 -4
Fix fatal errors from b2586aemediawiki/extensions/Translatewmf/1.33.0-wmf.1+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Oct 25 2018, 8:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2018, 8:36 AM
Mainframe98 subscribed.Oct 25 2018, 8:39 AM

Same error as with T207928: PHP fatal error when deleting a translatable category on MediaWiki.org.

Trainblocker?

Mainframe98 added a subscriber: cscott.Oct 25 2018, 8:46 AM

Presumably caused by rETRAb2586aebd94d: Avoid untidy calls to OutputPage::addWikiText(). Cc'ing @cscott as author of the patch.

Trizek-WMF added a comment.Oct 25 2018, 8:50 AM
In T207930#4693990, @Mainframe98 wrote:

Same error as with T207928: PHP fatal error when deleting a translatable category on MediaWiki.org.

Looks like it.

I don't have that issue on Meta.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Oct 25 2018, 9:06 AM
Nikerabbit added a project: MediaWiki Language Extension Bundle.
Nikerabbit merged a task: T207928: PHP fatal error when deleting a translatable category on MediaWiki.org.
Nikerabbit added a project: Wikimedia-production-error.Oct 25 2018, 9:08 AM
Nikerabbit added a parent task: T206655: 1.33.0-wmf.1 deployment blockers.
MGChecker renamed this task from Move a translatable page on mediawiki.org triggers an error message to Moving or deleting a translatable page on mediawiki.org triggers an error message.Oct 25 2018, 9:37 AM
MGChecker added subscribers: Shirayuki, Ciencia_Al_Poder.
MGChecker subscribed.
MGChecker added a comment.Oct 25 2018, 9:41 AM

Reported at MediaWiki.org as well.

gerritbot subscribed.Oct 25 2018, 12:46 PM

Change 469609 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Fix fatal errors from b2586ae

https://gerrit.wikimedia.org/r/469609

gerritbot added a project: Patch-For-Review.Oct 25 2018, 12:46 PM
Nikerabbit triaged this task as Unbreak Now! priority.Oct 25 2018, 12:48 PM
Nikerabbit added a project: Language-Team (Language-2018-October-December).
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 25 2018, 12:48 PM
Nikerabbit moved this task from Backlog to In Review on the Language-Team (Language-2018-October-December) board.Oct 25 2018, 12:48 PM
Nikerabbit moved this task from Backlog to 2018.10 on the MediaWiki Language Extension Bundle board.
gerritbot added a comment.Oct 25 2018, 1:16 PM

Change 469609 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix fatal errors from b2586ae

https://gerrit.wikimedia.org/r/469609

Nikerabbit subscribed.Oct 25 2018, 1:27 PM

Fix has been merged to master. I would appreciate if someone else backports and deploys it, as I am not around for SWAT.

Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2018-October-December) board.Oct 25 2018, 1:27 PM
Nikerabbit removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 25 2018, 2:00 PM
• Petar.petkovic assigned this task to Nikerabbit.Oct 25 2018, 2:24 PM
gerritbot added a comment.Oct 25 2018, 4:46 PM

Change 469650 had a related patch set uploaded (by Greg Grossmeier; owner: Nikerabbit):
[mediawiki/extensions/Translate@wmf/1.33.0-wmf.1] Fix fatal errors from b2586ae

https://gerrit.wikimedia.org/r/469650

gerritbot added a project: Patch-For-Review.Oct 25 2018, 4:46 PM
gerritbot added a comment.Oct 25 2018, 5:56 PM

Change 469650 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.33.0-wmf.1] Fix fatal errors from b2586ae

https://gerrit.wikimedia.org/r/469650

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.1; 2018-10-23); removed MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 25 2018, 6:01 PM
• mmodell subscribed.Oct 25 2018, 8:08 PM

Trizek-WMF: Can you confirm that this is fixed now? The patch has been deployed to group0.

cscott added a comment.Oct 25 2018, 8:59 PM

Verified that rETRAb2586aebd94d: Avoid untidy calls to OutputPage::addWikiText() didn't make it to the REL1_32 branch of Translate, and so no further backporting should be needed.

Thanks for fixing my mess.

Jdforrester-WMF closed this task as Resolved.Oct 26 2018, 12:07 AM
MGChecker removed a project: Patch-For-Review.Oct 26 2018, 12:13 AM
Trizek-WMF added a comment.Oct 26 2018, 8:34 AM
In T207930#4695660, @mmodell wrote:

Trizek-WMF: Can you confirm that this is fixed now? The patch has been deployed to group0.

It works!

Thank you everyone for the quick fix. :)

Liuxinyu970226 unsubscribed.Oct 27 2018, 8:49 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL