fiwiki Wikipedia:Virstanpylväät 17655361
and others.
fiwiki Wikipedia:Virstanpylväät 17655361
and others.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Accept spaces at the end of table_start_tag | mediawiki/services/parsoid | master | +15 -5 |
Change 469684 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Throws from TSP re-tokenizing
While the above patch fixes the crasher and improves the rendering from before it was exposed, there's still some work to do to match the php parser's output.
It seems like the token stream patcher needs to buffer all the tokens until the end of the line that are in table start tag attribute position and then stringify them if we're going to be retokenizing the start tag.
Just noting the original reduced test case as,
<noinclude>
<!--
--></noinclude>{|There's a space after the table start tag.
Without digging into the details, is this lintable and classifiable as 'unsupported' behavior?
Change 469684 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Accept spaces at the end of table_start_tag
The source on that fiwiki page is pretty much,
<noinclude>
<!--
--></noinclude{| <includeonly>border="0" style="background: none" </includeonly><noinclude>class="wikitable"
</noinclude>We probably support that kind of attribute tokenizing in other circumstances where we don't end up the token stream patcher.
TBH, I'm not really sure what use cases the token stream patchers in handling or why we end up there at all in this case.
Going to repurpose this task now that the fix for the crasher is merged.