Page MenuHomePhabricator
Create Task
Maniphest T207987

[betalabs-regression] RC/Watchlist guided tours missing rc-beta-tour-welcome-ltr.gif
Closed, ResolvedPublic
Actions

Description

In betalabs, reset your preferences to see guided tours on RC and Watchlist. The guided tours will not display rc-beta-tour-welcome-ltr.gif

Screen Shot 2018-10-25 at 1.09.35 PM.png (707×1 px, 276 KB)

https://en.wikipedia.beta.wmflabs.org/w/extensions/WikimediaMessages/modules/images/rc-beta-tour-welcome-ltr.gif gives "Unknown file path".

Thanks to @Volker_E's debugging, it seems that it happened due to changes made https://phabricator.wikimedia.org/T196033.

Note: Giuded tours are fine in production.

Details

SubjectRepoBranchLines +/-
RCFilters tour: add imagesmediawiki/extensions/WikimediaMessagesmaster+0 -0
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Oct 25 2018, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2018, 8:23 PM
Etonkovidova updated the task description. (Show Details)Oct 25 2018, 8:24 PM
SBisson claimed this task.Oct 25 2018, 8:35 PM

Oups, I cleaned up the beta feature and associated tours but I missed the fact that the welcome tour was using the beta tour's image.

I'll bring it back.

gerritbot subscribed.Oct 26 2018, 10:54 AM

Change 469858 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/WikimediaMessages@master] RCFiters tour: add images

https://gerrit.wikimedia.org/r/469858

gerritbot added a project: Patch-For-Review.Oct 26 2018, 10:54 AM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)), Edit-Review-Improvements-RC-Page; removed Growth-Team.Oct 26 2018, 10:55 AM
SBisson moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 26 2018, 5:52 PM
gerritbot added a comment.Oct 26 2018, 6:00 PM

Change 469858 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] RCFilters tour: add images

https://gerrit.wikimedia.org/r/469858

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 26 2018, 6:00 PM
Etonkovidova closed this task as Resolved.Oct 26 2018, 9:59 PM

Checked the fix in betalabs - rc-beta-tour-welcome-ltr.gif is back

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL