Page MenuHomePhabricator
Create Task
Maniphest T208070

Parse requests return gratuitous newlines
Closed, ResolvedPublic
Actions

Description

Parsoid makes parse requests to the MediaWiki API for extensions where
it doesn't have a native implementation. The php parser sometimes
returns trailing newlines which wouldn't be present from the extension
if it were being unstripped inline, since it tacks these on at eof.

From https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/469355/

Details

SubjectRepoBranchLines +/-
Get rid of trailing newline stripping of parse requestsmediawiki/services/parsoidmaster+2 -27
Update tests to match parser changesmediawiki/extensions/wikihieromaster+0 -10
Update tests to match parser changesmediawiki/extensions/intersectionmaster+0 -4
Update tests to match parser changesmediawiki/extensions/Graphmaster+0 -1
Avoid counting input lines twice in BlockLevelPass::execute()mediawiki/corewmf/1.33.0-wmf.22+6 -6
BlockLevelPass: further fixes for T218817mediawiki/corewmf/1.33.0-wmf.22+5 -2
Avoid counting input lines twice in BlockLevelPass::execute()mediawiki/coremaster+6 -6
BlockLevelPass: further fixes for T218817mediawiki/coremaster+5 -2
BlockLevelPass: further fixes for T218817mediawiki/coremaster+5 -2
parser: Omit outputting newline after final linemediawiki/coremaster+77 -492
Update tests to match parser changesmediawiki/extensions/Kartographermaster+3 -14
Update tests to match parser changesmediawiki/extensions/Scribuntomaster+0 -2
Update tests to match parser changesmediawiki/extensions/SyntaxHighlight_GeSHimaster+0 -9
Revert "Temporarily trim leading/trailing whitespace from parser test clauses"mediawiki/coremaster+0 -4
Update tests to match parser changesmediawiki/extensions/ParserFunctionsmaster+0 -1
Update tests to match parser changesmediawiki/extensions/Citemaster+0 -41
Update tests to match parser changesmediawiki/extensions/TimedMediaHandlermaster+0 -10
Update tests to match parser changesmediawiki/extensions/ImageMapmaster+0 -1
parser: Remove trailing newline after prefixes have been clearedmediawiki/coremaster+9 -83
Update tests to match parser changesmediawiki/extensions/ParserFunctionsmaster+0 -1
Temporarily trim leading/trailing whitespace from parser test clausesmediawiki/coremaster+4 -0
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Oct 26 2018, 5:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2018, 5:10 PM
Arlolra triaged this task as Medium priority.Dec 17 2018, 8:52 PM
Arlolra added a project: MediaWiki-Parser.Dec 20 2018, 12:56 AM
gerritbot subscribed.Dec 20 2018, 12:59 AM

Change 480889 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Remove trailing newline after prefixes have been cleared

https://gerrit.wikimedia.org/r/480889

gerritbot added a project: Patch-For-Review.Dec 20 2018, 12:59 AM

Change 480890 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Omit outputting newline after final line

https://gerrit.wikimedia.org/r/480890

gerritbot added a comment.Mar 7 2019, 3:09 PM

Change 494938 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/ParserFunctions@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494938

gerritbot added a comment.Mar 7 2019, 3:13 PM

Change 494939 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/ParserFunctions@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494939

gerritbot added a comment.Mar 7 2019, 3:26 PM

Change 494945 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/Cite@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494945

gerritbot added a comment.Mar 7 2019, 3:35 PM

Change 494961 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/TimedMediaHandler@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494961

gerritbot added a comment.Mar 7 2019, 3:43 PM

Change 494964 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/ImageMap@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494964

gerritbot added a comment.Mar 15 2019, 6:23 PM

Change 496845 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Temporarily trim leading/trailing whitespace from parser test clauses

https://gerrit.wikimedia.org/r/496845

gerritbot added a comment.Mar 15 2019, 6:23 PM

Change 496846 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Revert "Temporarily trim leading/trailing whitespace from parser test clauses"

https://gerrit.wikimedia.org/r/496846

gerritbot added a comment.Mar 19 2019, 2:07 PM

Change 494939 had a related patch set uploaded (by C. Scott Ananian; owner: Arlolra):
[mediawiki/extensions/ParserFunctions@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494939

gerritbot added a comment.Mar 19 2019, 2:18 PM

Change 496845 merged by jenkins-bot:
[mediawiki/core@master] Temporarily trim leading/trailing whitespace from parser test clauses

https://gerrit.wikimedia.org/r/496845

gerritbot added a comment.Mar 19 2019, 2:18 PM

Change 494938 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494938

gerritbot added a comment.Mar 19 2019, 2:18 PM

Change 480889 merged by jenkins-bot:
[mediawiki/core@master] parser: Remove trailing newline after prefixes have been cleared

https://gerrit.wikimedia.org/r/480889

gerritbot added a comment.Mar 19 2019, 2:18 PM

Change 494964 merged by jenkins-bot:
[mediawiki/extensions/ImageMap@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494964

gerritbot added a comment.Mar 19 2019, 2:18 PM

Change 494961 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494961

gerritbot added a comment.Mar 19 2019, 2:18 PM

Change 494945 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494945

gerritbot added a comment.Mar 19 2019, 2:37 PM

Change 494939 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/494939

gerritbot added a comment.Mar 19 2019, 2:37 PM

Change 480890 merged by jenkins-bot:
[mediawiki/core@master] parser: Omit outputting newline after final line

https://gerrit.wikimedia.org/r/480890

gerritbot added a comment.Mar 19 2019, 2:37 PM

Change 496846 merged by jenkins-bot:
[mediawiki/core@master] Revert "Temporarily trim leading/trailing whitespace from parser test clauses"

https://gerrit.wikimedia.org/r/496846

Arlolra closed this task as Resolved.Mar 19 2019, 2:59 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 19 2019, 3:01 PM
gerritbot added a comment.Mar 19 2019, 5:14 PM

Change 497564 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/Scribunto@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/497564

gerritbot added a comment.Mar 19 2019, 5:38 PM

Change 497571 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/497571

gerritbot added a comment.Mar 19 2019, 5:52 PM

Change 497577 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/Kartographer@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/497577

gerritbot added a comment.Mar 19 2019, 6:35 PM

Change 497571 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/497571

gerritbot added a comment.Mar 19 2019, 6:35 PM

Change 497564 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/497564

gerritbot added a comment.Mar 19 2019, 6:54 PM

Change 497577 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/497577

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 19 2019, 7:01 PM
gerritbot added a comment.Mar 20 2019, 8:49 PM

Change 497865 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Avoid counting input lines twice in BlockLevelPass::execute()

https://gerrit.wikimedia.org/r/497865

gerritbot added a comment.Mar 20 2019, 9:21 PM

Change 497879 had a related patch set uploaded (by C. Scott Ananian; owner: Arlolra):
[mediawiki/core@master] BlockLevelPass: further fixes for T218817

https://gerrit.wikimedia.org/r/497879

gerritbot added a comment.Mar 20 2019, 9:31 PM

Change 497871 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] BlockLevelPass: further fixes for T218817

https://gerrit.wikimedia.org/r/497871

gerritbot added a comment.Mar 20 2019, 9:32 PM

Change 497879 abandoned by Arlolra:
BlockLevelPass: further fixes for T218817

Reason:
As PS4 on https://gerrit.wikimedia.org/r/c/mediawiki/core/ /497871

https://gerrit.wikimedia.org/r/497879

gerritbot added a comment.Mar 20 2019, 9:45 PM

Change 497871 merged by jenkins-bot:
[mediawiki/core@master] BlockLevelPass: further fixes for T218817

https://gerrit.wikimedia.org/r/497871

gerritbot added a comment.Mar 20 2019, 9:53 PM

Change 497865 merged by jenkins-bot:
[mediawiki/core@master] Avoid counting input lines twice in BlockLevelPass::execute()

https://gerrit.wikimedia.org/r/497865

gerritbot added a comment.Mar 20 2019, 10:44 PM

Change 497940 had a related patch set uploaded (by Jforrester; owner: Arlolra):
[mediawiki/core@wmf/1.33.0-wmf.22] BlockLevelPass: further fixes for T218817

https://gerrit.wikimedia.org/r/497940

gerritbot added a comment.Mar 20 2019, 10:44 PM

Change 497941 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@wmf/1.33.0-wmf.22] Avoid counting input lines twice in BlockLevelPass::execute()

https://gerrit.wikimedia.org/r/497941

gerritbot added a comment.Mar 21 2019, 12:05 AM

Change 497940 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.22] BlockLevelPass: further fixes for T218817

https://gerrit.wikimedia.org/r/497940

gerritbot added a comment.Mar 21 2019, 12:06 AM

Change 497941 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.22] Avoid counting input lines twice in BlockLevelPass::execute()

https://gerrit.wikimedia.org/r/497941

gerritbot added a comment.Mar 21 2019, 4:05 PM

Change 498137 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/Graph@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/498137

gerritbot added a comment.Mar 21 2019, 4:25 PM

Change 498137 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/498137

gerritbot added a comment.Mar 22 2019, 3:56 PM

Change 498412 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/intersection@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/498412

gerritbot added a comment.Mar 22 2019, 4:35 PM

Change 498412 merged by jenkins-bot:
[mediawiki/extensions/intersection@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/498412

gerritbot added a comment.Mar 24 2019, 8:49 AM

Change 498701 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/wikihiero@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/498701

gerritbot added a comment.Mar 24 2019, 3:29 PM

Change 498701 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Update tests to match parser changes

https://gerrit.wikimedia.org/r/498701

gerritbot added a comment.Sep 27 2019, 3:48 PM

Change 539561 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Get rid of trailing newline stripping of parse requests

https://gerrit.wikimedia.org/r/539561

gerritbot added a comment.Sep 27 2019, 4:37 PM

Change 539561 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Get rid of trailing newline stripping of parse requests

https://gerrit.wikimedia.org/r/539561

Stashbot added a comment.Sep 30 2019, 8:43 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T20:43:27Z] <arlolra> T208070

Stashbot mentioned this in T233459: Undefined property: stdClass::$src in TokenUtils.php::tokensToString.Sep 30 2019, 8:43 PM
Stashbot mentioned this in T230359: Create N'Ko Wikipedia.

Mentioned in SAL (#wikimedia-operations) [2019-09-30T20:43:35Z] <arlolra> Updated Parsoid to 1922eb6 (T233459, T230359, T208070)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL