Page MenuHomePhabricator
Create Task
Maniphest T208102

Improve compatibility of desktop VisualEditor with desktop Minerva skin
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Oct 26 2018, 10:21 PM
Tags
Referenced Files
F27080247: image.png
Nov 6 2018, 4:37 PM
F27080258: image.png
Nov 6 2018, 4:37 PM
F26862590: image.png
Oct 26 2018, 10:26 PM
F26860539: image.png
Oct 26 2018, 10:21 PM
F26860529: image.png
Oct 26 2018, 10:21 PM
Subscribers
Aklapper
gerritbot
matmarex

Description

Currently, on the desktop Minerva skin, the mobile editor is loaded. If you somehow cheat and load the desktop VisualEditor instead (e.g. https://gerrit.wikimedia.org/r/470087), it works mostly fine!, but there are a few issues I noticed:

In view mode:

BeforeAfter
image.png (980×1 px, 457 KB)
image.png (980×1 px, 461 KB)
  • https://gerrit.wikimedia.org/r/470089 Two-tab mode doesn't quite work:
    • No secondary tab is inserted at the top of the page, the only tab always opens the source editor
    • Secondary section edit links are inserted, but they are indistinguishable from the originals
    • Link dividers look weird (huge font size)

In edit mode:

BeforeAfter
image.png (980×1 px, 419 KB)
image.png (980×1 px, 421 KB)

Details

SubjectRepoBranchLines +/-
ve.init.mw.DesktopArticleTarget.init: Update for Minerva changesmediawiki/extensions/VisualEditormaster+22 -26
Switch to outside list style for ordered lists toomediawiki/skins/MinervaNeuemaster+2 -1
ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minervamediawiki/extensions/VisualEditormaster+20 -0
MWTempWikitextEditorWidget: Don't rely on skin to set width for textareasmediawiki/extensions/VisualEditormaster+1 -0
ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minervamediawiki/extensions/VisualEditormaster+87 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Oct 26 2018, 10:21 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 26 2018, 10:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a subtask: T208068: Can't open the visual editor on MinervaNeue on desktop.Oct 26 2018, 10:21 PM
matmarex added a parent task: T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).
gerritbot subscribed.Oct 26 2018, 10:23 PM

Change 470089 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva

https://gerrit.wikimedia.org/r/470089

gerritbot added a project: Patch-For-Review.Oct 26 2018, 10:23 PM
matmarex added a comment.Oct 26 2018, 10:26 PM
This comment was removed by matmarex.
matmarex claimed this task.Oct 26 2018, 10:27 PM
• marcella edited projects, added VisualEditor (Current work); removed VisualEditor.Oct 29 2018, 2:32 PM
• marcella moved this task from Incoming to In progress on the VisualEditor (Current work) board.
matmarex mentioned this in T208068: Can't open the visual editor on MinervaNeue on desktop.Nov 6 2018, 12:23 AM
gerritbot added a comment.Nov 6 2018, 4:30 PM

Change 471999 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] MWTempWikitextEditorWidget: Don't rely on skin to set width for textareas

https://gerrit.wikimedia.org/r/471999

gerritbot added a comment.Nov 6 2018, 4:30 PM

Change 472000 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva

https://gerrit.wikimedia.org/r/472000

matmarex updated the task description. (Show Details)Nov 6 2018, 4:37 PM
matmarex moved this task from In progress to QA on the VisualEditor (Current work) board.Nov 6 2018, 4:42 PM

These patches fix the most glaring issues (they were also mostly straightforward to fix). See task description for screenshots.

I am not planning to work on the remaining issues I noticed – they are IMO less important and also seem more tricky to fix. Desktop Minerva is not a priority right now, I think, so I don't really have time to spend on it. We should file separate tasks about them later.

matmarex moved this task from QA to Code review on the VisualEditor (Current work) board.Nov 6 2018, 4:42 PM
gerritbot added a comment.Nov 7 2018, 12:26 PM

Change 470089 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva

https://gerrit.wikimedia.org/r/470089

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 1:00 PM
gerritbot added a comment.Nov 7 2018, 1:18 PM

Change 471999 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTempWikitextEditorWidget: Don't rely on skin to set width for textareas

https://gerrit.wikimedia.org/r/471999

gerritbot added a comment.Nov 7 2018, 1:18 PM

Change 472000 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva

https://gerrit.wikimedia.org/r/472000

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 7 2018, 4:55 PM
Ryasmeen added a project: Editing QA.Nov 7 2018, 6:41 PM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Nov 14 2018, 4:32 PM
matmarex mentioned this in T186735: VisualEditor toolbar overlaps with desktop Minerva header.Nov 20 2018, 5:59 AM
gerritbot added a comment.Feb 8 2019, 5:40 PM

Change 489272 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] Switch to outside list style for ordered lists too

https://gerrit.wikimedia.org/r/489272

Esanders mentioned this in T210630: [Engineering EPIC]: Loading screen improvements.Feb 9 2019, 7:23 PM
gerritbot added a comment.Feb 11 2019, 8:13 PM

Change 489272 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Switch to outside list style for ordered lists too

https://gerrit.wikimedia.org/r/489272

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.17; 2019-02-12); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Feb 11 2019, 9:00 PM
matmarex updated the task description. (Show Details)Feb 18 2019, 10:58 PM
matmarex mentioned this in T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.Feb 20 2019, 10:12 PM
matmarex removed a project: Patch-For-Review.Feb 22 2019, 1:23 AM
matmarex updated the task description. (Show Details)
matmarex mentioned this in T216792: Ordered lists look broken in mobile VE.Feb 22 2019, 1:59 AM
matmarex added a subtask: T216792: Ordered lists look broken in mobile VE.
ppelberg closed subtask T208068: Can't open the visual editor on MinervaNeue on desktop as Resolved.Feb 28 2019, 11:48 PM
gerritbot added a comment.Mar 26 2019, 8:32 PM

Change 499321 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes

https://gerrit.wikimedia.org/r/499321

gerritbot added a project: Patch-For-Review.Mar 26 2019, 8:32 PM
matmarex mentioned this in T190989: On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors.Mar 26 2019, 8:36 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Apr 2 2019, 9:15 PM
Ryasmeen added a project: Verified.
Ryasmeen removed a project: Editing QA.Apr 2 2019, 11:01 PM
matmarex edited projects, added MinervaNeue (Desktop); removed MinervaNeue.Apr 12 2019, 12:40 AM
gerritbot added a comment.Apr 26 2019, 8:48 PM

Change 499321 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes

https://gerrit.wikimedia.org/r/499321

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 26 2019, 9:00 PM
matmarex removed a parent task: T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).May 1 2019, 8:56 PM
ppelberg closed subtask T216792: Ordered lists look broken in mobile VE as Resolved.May 3 2019, 9:51 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:45 PM
ppelberg closed this task as Resolved.May 24 2019, 11:09 PM
matmarex mentioned this in T186149: [betalabs] Cannot switch to VE in MinervaNeue .Jan 28 2020, 12:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits