Page MenuHomePhabricator

Add 'articlesSearch' icon: No page search result features wrong icon
Closed, ResolvedPublic

Description

The 'no page found' search result features an outdated icon with wrong stroke width:

image.png (338×856 px, 42 KB)
image.png (974×874 px, 239 KB)
Proposal

image.png (224×184 px, 4 KB)

In Design review it was also quickly discussed to not have an icon at all. But that was out of wrong context provided in presentation. See discussion below to see agreement that we should use an icon.

Event Timeline

Have we got the new icon asset?

This should probably feature an icon mashup of ' 'referenceExisting' and 'articleSearch'

From today's Design meeting:
An option brought up by @schoenbaechler actually got most traction, having no icon there at all, which would also do away with the weird vertical alignment of the title vs results below.

Volker_E updated the task description. (Show Details)

In conversation with @alexhollender we've also tried

image.png (684×856 px, 158 KB)

I think we should anchor on the use case where the search returns results because that's more common. I think it looks better with the proposed icon rather than no icon.

icon
image.png (1×750 px, 305 KB)
image.png (1×750 px, 46 KB)
no icon
image.png (1×750 px, 303 KB)
image.png (1×750 px, 44 KB)

From today's Design meeting:
An option brought up by @schoenbaechler actually got most traction, having no icon there at all, which would also do away with the weird vertical alignment of the title vs results below.

I think previously we (or at least I) misunderstood the icon was about conveying that there are no search results only and for users to start a new search, but seeing it in context it does make sense.

I think we should anchor on the use case where the search returns results because that's more common. I think it looks better with the proposed icon rather than no icon.

icon
image.png (1×750 px, 305 KB)
image.png (1×750 px, 46 KB)
no icon
image.png (1×750 px, 303 KB)
image.png (1×750 px, 44 KB)

+1 for icon, though can search in pages icon and Search within pages text be shift a couple pixels to the left so that they are aligned with the search icon and the search term respectively?

From today's Design meeting:
An option brought up by @schoenbaechler actually got most traction, having no icon there at all, which would also do away with the weird vertical alignment of the title vs results below.

I think previously we (or at least I) misunderstood the icon was about conveying that there are no search results only and for users to start a new search, but seeing it in context it does make sense.

Yes, I also misunderstood it @RHo. But after seeing it in its “natural environment” I’m also for using an icon. Especially since it emphasizes the meaning of “Search within pages”.

Thx @alexhollender + @Volker_E!

Change 593655 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Add 'articlesSearch' icon

https://gerrit.wikimedia.org/r/593655

This comment was removed by Esanders.

Does this need a new icon? I don't understand the semantic difference between 'search' and 'articlesSearch'?

Change 593655 merged by jenkins-bot:
[oojs/ui@master] icons: Add 'articlesSearch' icon

https://gerrit.wikimedia.org/r/593655

Change 593819 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.38.1

https://gerrit.wikimedia.org/r/593819

@Esanders Search in one article. Search in page. Versus search across objects.

Change 593819 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.38.1

https://gerrit.wikimedia.org/r/593819

Search in one article. Search in page. Versus search across objects.

That's the difference between articleSearch and search, but what about articlesSearch. As far as I can see it is for search for content across multiple pages, but that is exactly what regular search does.

Search results are differently visualized ('articlesSearch') than the search ('search') action itself.

Change 593832 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Replace 'mobile.startup.images' module icons with OOUI ones

https://gerrit.wikimedia.org/r/593832

The screenshot in the description does not show search results, but a link to perform the search action.

@Esanders Added second screen to task description.

Change 593832 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace 'mobile.startup.images' module icons with OOUI ones

https://gerrit.wikimedia.org/r/593832

Captured the other comments about misalignment/usability in T251840.

Volker_E renamed this task from No page search result features wrong icon to Add 'articlesSearch' icon: No page search result features wrong icon.Aug 23 2021, 8:47 PM