I recently merged a change that showed a post build error here: https://integration.wikimedia.org/ci/job/mwext-jsduck-publish/8057/console
(T207386)
I have traced this to this merged change here adding the wikibase termbox repository from phabricator:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/469323/ (T207042)
Presumably this means that jsduck needs to be told to skip these non compliant files somehow. Currently it runs on everything in /view/.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| jsduck: disable for termbox | mediawiki/extensions/Wikibase | master | +2 -1 |
"Support ES6 syntax" is an open ticket for around 3 years in jsduck - yet to be addressed given support pretty much died down.
Yeah, we should exclude it from the build then.
This is the generated documentation here: https://doc.wikimedia.org/Wikibase/master/js/#!/api/jQuery.wikibase.snakview
But we can't build a new one because this breaks it.
It doesn't look like term box needs to be documented there anyway?
Change 470857 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] jsduck: disable for termbox
Change 470857 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] jsduck: disable for termbox
Hi @Lea_WMDE,
this was a bug in generating the documentation. That is, if it is not blowing up while generating, and the date stated in the doc (to be seen in the HTML source as currently Mon 12 Nov 2018 02:11:05) is not too far in the past, we are good. That said: maybe it should never have been put into "product review"; I moved it to done now.
This best way to test this would be to see if T207386 is deployed successfully, but I hadn't included the ticket number. It works: the build is now being run, you can see that from https://doc.wikimedia.org/Wikibase/master/js/#!/api/jQuery.wikibase.snakview.variations