Page MenuHomePhabricator

Legalpad access controls are confusing and seemingly broken
Closed, ResolvedPublic


@JeanFred is unable to save changes to a legalpad document because "only admins may require signature" despite the fact that the form doesn't even have the "require signature" checkbox when viewed by a non-admin.

Event Timeline

mmodell triaged this task as High priority.Oct 29 2018, 6:27 PM
mmodell created this task.

let him try again now. it's possible it was just me doing it wrong in the custom policy all this time.

Mentioned in SAL (#wikimedia-operations) [2018-10-29T19:03:17Z] <twentyafterfour> restart apache on phab1001 to hotfix T208254

Mentioned in SAL (#wikimedia-operations) [2018-10-30T20:22:15Z] <twentyafterfour> hotfixing T208254 (restarting apache2 on phab1001)

I've applied a substantially similar patch to the upstream in the upcoming 2019 Week 13 release, see for details. You'll likely hit conflicts when updating, but the intent of the two changes is identical, so my expectation is that you can discard the forked version safely.

I wasn't able to figure out how to actually reproduce this locally, but the patch in D1123 is broadly more correct than the old behavior even if the pathway to get there involved some kind of local patch I wasn't able to dig up or only happened on older versions of Phabricator or whatever.

Thank you @epriestley! I resolved the conflict and this will get deployed with the upstream version soon. Much appreciated!

Closing as per last comment as a more recent software version is now deployed on
If this is still a problem, then please set the status of this report back to "Open" via the Add Action...Change Status dropdown. Thanks!