Page MenuHomePhabricator
Create Task
Maniphest T208273

Partially blocked users should be able to rename/move pages (outside their block)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Problem

This was tested on the beta environment on October 29, 2018 and reproduced on Test Wiki.

Users can rename (aka move) pages:

Screen Shot 2018-10-29 at 3.32.43 PM.png (943×1 px, 303 KB)

Defect: On the beta environment, if a user is partially blocked they cannot rename any page. https://en.wikipedia.beta.wmflabs.org/wiki/Special:MovePage/Argos_(dog)

Screen Shot 2018-10-29 at 3.30.43 PM.png (943×1 px, 267 KB)

Expected behavior

  • If a user is partially blocked from a page they should be allowed to rename all other pages except for the blocked page(s).
    • For example, if a user is blocked from Mars they should be able to rename Earth but not be able to rename Mars

Related Objects
Search...

Event Timeline

• TBolliger created this task.Oct 29 2018, 10:35 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptOct 29 2018, 10:35 PM
• TBolliger triaged this task as Medium priority.Oct 29 2018, 10:43 PM
• TBolliger added a project: MediaWiki-User-management.Nov 2 2018, 4:45 PM
• TBolliger added a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.
• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.
dbarratt removed a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:21 PM
dbarratt added a subtask: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:24 PM
• TBolliger raised the priority of this task from Medium to High.Nov 2 2018, 5:54 PM
• TBolliger mentioned this in T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.
dbarratt added a parent task: T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 2 2018, 5:57 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Nov 2 2018, 6:26 PM
• TBolliger set the point value for this task to 3.

Needs to check to and from — moving from a blocked page and moving to a blocked page/namespace.

dbarratt added a subtask: T205895: Title::checkUserBlock does not return an an error if User::isBlockedFrom() returns true and Block::prevents('edit') returns false.Nov 6 2018, 3:53 PM
dbarratt removed a subtask: T205895: Title::checkUserBlock does not return an an error if User::isBlockedFrom() returns true and Block::prevents('edit') returns false.
dbarratt added a subtask: T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock.Nov 6 2018, 3:55 PM
• TBolliger renamed this task from Partially blocked users should be able to rename pages to Partially blocked users should be able to rename/move pages (outside their block).Nov 7 2018, 5:19 PM
• TBolliger merged a task: T208857: A partially blocked user should be able to perform page moves on unrelated pages.
• TBolliger updated the task description. (Show Details)
• TBolliger added subscribers: • SPoore, Oshwah, Thryduulf, dbarratt.
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment.Nov 7 2018, 10:10 PM
• TBolliger mentioned this in T206031: "You are blocked" messages should be contextually specific when a partially blocked user is performing non-editing actions (upload, email user, move page, etc.).Nov 8 2018, 6:29 PM
dbarratt changed the task status from Open to Stalled.Nov 8 2018, 10:23 PM
• TBolliger added a comment.Nov 9 2018, 6:46 PM

Confirmed fixed on https://thegoodplace.wmflabs.org/wiki/Special:Log

Screen Shot 2018-11-09 at 10.45.46 AM.png (586×867 px, 69 KB)

dbarratt assigned this task to • TBolliger.Nov 12 2018, 2:39 PM
dbarratt moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 33) board.
• TBolliger added a comment.Nov 12 2018, 5:50 PM

We can mark this as resolved once the corresponding technical task is closed.

• TBolliger closed this task as Resolved.Nov 15 2018, 5:48 PM
• TBolliger moved this task from Review to Done on the Anti-Harassment (AHT Sprint 33) board.
• TBolliger reopened subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Open.Nov 19 2018, 9:50 PM
• TBolliger closed subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Resolved.Nov 19 2018, 10:00 PM
dbarratt closed subtask T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock as Resolved.Nov 19 2018, 11:30 PM
• TBolliger reopened subtask T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock as Open.Dec 3 2018, 5:06 PM
dbarratt closed subtask T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock as Resolved.Jan 8 2019, 9:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL