Page MenuHomePhabricator

[bug]? text wrapping in the hover box needs improvement
Closed, ResolvedPublic1 Estimated Story Points

Description

Problem statement
The text wrapping is breaking in places that make it really hard to read the text, as well as not using the common "-" to connect the two text parts.

Current situation

Screenshot_20181030_151825.png (230×345 px, 19 KB)

Acceptance criteria

  • The text wrapping should not split words OR
  • the text wrapping should split words after syllables and indicate this with a "-" at the end of the first fragment

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 472468 had a related patch set uploaded (by Vijay9908; owner: Vijay9908):
[mediawiki/core@master] "Bug: T208318 text wrapping in the hover box needs improvement fixed"

https://gerrit.wikimedia.org/r/472468

Change 472468 abandoned by Vijay9908:
"Bug: T208318 text wrapping in the hover box needs improvement fixed"

Reason:
Will fix it later

https://gerrit.wikimedia.org/r/472468

Gopavasanth added subscribers: Vijay9908, Gopavasanth.

Sorry, As you don't have any updates so far, Please feel free to re-assign yourself if you are planning to work.

I was searching around and found few insights, One possible way could be adding a class to the rev.getParsedComment() at line 510 and adding CSS properties hypens: auto / break-word: normal to the class should solve this bug I guess.

@WMDE-Fisch what do you think?

I was searching around and found few insights, One possible way could be adding a class to the rev.getParsedComment() at line 510 and adding CSS properties hypens: auto / break-word: normal to the class should solve this bug I guess.

@WMDE-Fisch what do you think?

Sounds like a plan :-)

@Gopavasanth want to earn some karma credits by doing this change? Otherwise I would fix it as part of our current maintenance sprint ;-).

Change 638367 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/RevisionSlider@master] Fixed text wrapping to avoid word break in tooltip

https://gerrit.wikimedia.org/r/638367

Results of the above patch-set

before (214×323 px, 24 KB)
Before
after (145×235 px, 24 KB)
After

@WMDE-Fisch how's this change looks?

Change 638367 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fixed text wrapping to avoid word break in tooltip

https://gerrit.wikimedia.org/r/638367

Gopavasanth claimed this task.