Page MenuHomePhabricator

Improve handling of non-existent entities in formatters
Open, Needs TriagePublic


A missing null-check in an EntityLinkFormatter recently caused issues: T208142. LexemeIdHtmlFormatter and LexemeLinkFormatter (fixing patch both are missing the null-check as well.

Other EntityIdFormatters implement different ways to fall back in case the entity does not exist. Maybe the right thing to do is to handle this within the dispatching formatter service, either by ensuring the entity that is to be formatted exists before it gets to the concrete formatter service, or by defining an exception that should be thrown and handled by the upper layer. The DispatchingEntityIdHtmlLinkFormatter already holds a NonExistingEntityIdHtmlFormatter that it could use.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2018, 2:55 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 30 2018, 2:55 PM