Page MenuHomePhabricator
Create Task
Maniphest T208347

Exception when opening any dialog/inspector in VE
Closed, ResolvedPublic
Actions

Description

On Beta, there's an exception when opening any dialog/inspector in VE. The window doesn't open.

In particular, this prevents saving changes.

Uncaught TypeError: surface.getSelectionDirectionality is not a function
    at VeUiWindowAction.ve.ui.WindowAction.open
    at VeUiMWSurface.ve.ui.Surface.execute
    at VeUiMWLinkAction.ve.ui.MWLinkAction.open
    at VeUiMWSurface.ve.ui.Surface.execute
    at VeUiCommand.ve.ui.Command.execute
    at VeUiLinkContextItem.ve.ui.LinearContextItem.onEditButtonClick
    at OoUiButtonWidget.oo.EventEmitter.emit
    at OoUiButtonWidget.OO.ui.mixin.ButtonElement.onClick
    at HTMLAnchorElement.dispatch
    at HTMLAnchorElement.elemData.handle

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to wmf/1.33.0-wmf.2 (3b7661b75)mediawiki/extensions/VisualEditorwmf/1.33.0-wmf.2+1 -1
Update VE core submodule to master (3dfcbdb3f)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.WindowAction: Fix exception when opening windowsVisualEditor/VisualEditorwmf/1.33.0-wmf.2+1 -1
ve.ui.WindowAction: Fix exception when opening windowsVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasethciprianiT206656 1.33.0-wmf.2 deployment blockers
 ResolvedmatmarexT208347 Exception when opening any dialog/inspector in VE

Event Timeline

matmarex created this task.Oct 30 2018, 7:47 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 30 2018, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex claimed this task.Oct 30 2018, 7:47 PM
matmarex triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 30 2018, 7:47 PM
gerritbot subscribed.Oct 30 2018, 7:47 PM

Change 470667 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.WindowAction: Fix exception when opening windows

https://gerrit.wikimedia.org/r/470667

gerritbot added a project: Patch-For-Review.Oct 30 2018, 7:47 PM
matmarex added a comment.Oct 30 2018, 7:48 PM

Caused by rGVED158a8eeb31b9: Refactor ve.ce.*Selection#getDirectionality, which was included in rEVED169602ea444f: Update VE core submodule to master (bef57a528), which is in 1.33.0-wmf.2. We will need to backport this fix.

matmarex added a parent task: T206656: 1.33.0-wmf.2 deployment blockers.Oct 30 2018, 7:50 PM
gerritbot added a comment.Oct 30 2018, 7:58 PM

Change 470667 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.WindowAction: Fix exception when opening windows

https://gerrit.wikimedia.org/r/470667

gerritbot added a comment.Oct 30 2018, 7:58 PM

Change 470672 had a related patch set uploaded (by Thcipriani; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@wmf/1.33.0-wmf.2] ve.ui.WindowAction: Fix exception when opening windows

https://gerrit.wikimedia.org/r/470672

gerritbot added a comment.Oct 30 2018, 8:06 PM

Change 470672 merged by Thcipriani:
[VisualEditor/VisualEditor@wmf/1.33.0-wmf.2] ve.ui.WindowAction: Fix exception when opening windows

https://gerrit.wikimedia.org/r/470672

gerritbot added a comment.Oct 30 2018, 8:12 PM

Change 470675 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3dfcbdb3f)

https://gerrit.wikimedia.org/r/470675

gerritbot added a comment.Oct 30 2018, 8:13 PM

Change 470676 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.2] Update VE core submodule to wmf/1.33.0-wmf.2

https://gerrit.wikimedia.org/r/470676

matmarex updated the task description. (Show Details)Oct 30 2018, 8:15 PM
gerritbot added a comment.Oct 30 2018, 8:34 PM

Change 470675 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3dfcbdb3f)

https://gerrit.wikimedia.org/r/470675

gerritbot added a comment.Oct 30 2018, 8:37 PM

Change 470676 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.2] Update VE core submodule to wmf/1.33.0-wmf.2 (3b7661b75)

https://gerrit.wikimedia.org/r/470676

Stashbot subscribed.Oct 30 2018, 8:45 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-30T20:45:33Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.2/extensions/VisualEditor/lib/ve/src/ui/actions/ve.ui.WindowAction.js: [[gerrit:470672|ve.ui.WindowAction: Fix exception when opening windows]] T208347 (duration: 00m 54s)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Oct 30 2018, 9:00 PM
Jdforrester-WMF mentioned this in T208366: JS fatal in VE from ve.ui.DesktopContext.prototype.updateDimensions.Oct 30 2018, 10:30 PM
Jdforrester-WMF mentioned this in T208228: DM Selections should not cache document model data.Oct 30 2018, 10:38 PM
Jdforrester-WMF edited projects, added: VisualEditor (Current work); removed: Patch-For-Review, VisualEditor.
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.Oct 30 2018, 10:40 PM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
Jdforrester-WMF subscribed.

De-prioritising as the train is unblocked now.

matmarex closed this task as Resolved.Oct 31 2018, 12:20 AM
matmarex raised the priority of this task from High to Unbreak Now!.

(I'm closing this task, contrary to our usual practice in VisualEditor, so that folks looking at T206656 can tell that it's not a blocker, since this is the usual practice for release blockers.)

Liuxinyu970226 unsubscribed.Nov 2 2018, 5:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits