Page MenuHomePhabricator
Create Task
Maniphest T208389

PHPUnit4And6Compat trait should forward port expectException
Closed, ResolvedPublic
Actions

Description

It would be great if in addition to back compatibility for setExpectedException the compat layer would also provide forward compatibility of expectException.

Details

SubjectRepoBranchLines +/-
Added future compat expectException to PHPUnit4And6Compat traitmediawiki/coremaster+14 -2
Customize query in gerrit

Event Timeline

Tarrow created this task.Oct 31 2018, 11:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2018, 11:49 AM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jan 25 2019, 10:58 PM
gerritbot subscribed.Feb 4 2019, 3:07 PM

Change 487149 had a related patch set uploaded (by Tarrow; owner: WMDE-leszek):
[mediawiki/core@master] Added future compat expectException to PHPUnit4And6Compat trait

https://gerrit.wikimedia.org/r/487149

gerritbot added a project: Patch-For-Review.Feb 4 2019, 3:07 PM
gerritbot added a comment.Feb 4 2019, 5:57 PM

Change 487149 merged by jenkins-bot:
[mediawiki/core@master] Added future compat expectException to PHPUnit4And6Compat trait

https://gerrit.wikimedia.org/r/487149

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Feb 4 2019, 6:00 PM
Jdforrester-WMF closed this task as Resolved.Feb 4 2019, 6:27 PM
Jdforrester-WMF assigned this task to WMDE-leszek.
Jdforrester-WMF removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits