146 Illegal offset type in /srv/mediawiki/php-1.33.0-wmf.2/includes/user/User.php on line 941 145 Array key should be either a string or an integer in /srv/mediawiki/php-1.33.0-wmf.2/includes/user/User.php on line 920
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | PRODUCTION ERROR | None | T199066 PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions | ||
Resolved | PRODUCTION ERROR | phuedx | T208469 Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string |
Event Timeline
Mentioned in SAL (#wikimedia-operations) [2018-10-31T21:43:34Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Temporary logging to debug T208469 (duration: 00m 57s)
Mentioned in SAL (#wikimedia-operations) [2018-10-31T21:47:04Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Temporary logging to debug T208469 (duration: 00m 53s)
Mentioned in SAL (#wikimedia-operations) [2018-10-31T21:55:55Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Temporary logging to debug T208469 (duration: 00m 51s)
Mentioned in SAL (#wikimedia-operations) [2018-10-31T22:03:12Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Temporary logging to debug T208469 (duration: 00m 53s)
Mentioned in SAL (#wikimedia-operations) [2018-10-31T22:06:40Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Temporary logging to debug T208469 (duration: 00m 53s)
Mentioned in SAL (#wikimedia-operations) [2018-10-31T22:17:12Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Temporary logging to debug T208469 (duration: 00m 53s)
Mentioned in SAL (#wikimedia-operations) [2018-10-31T22:19:18Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/includes/user/User.php: Revert debugging code for T208469 (duration: 00m 52s)
Change 470932 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@master] Fix PHP warnings in User.php
Change 470936 had a related patch set uploaded (by Jforrester; owner: Catrope):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.2] Fix PHP warnings in User.php
Mentioned in SAL (#wikimedia-operations) [2018-10-31T22:36:50Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.2/extensions/MobileFrontend/includes/specials/SpecialMobileContributions.php: Fix PHP warnings in User.php (T208469) (duration: 00m 53s)
Change 470940 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] User: Don't fail mysteriously when passing a User object to idFromName()
Change 470936 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.2] Fix PHP warnings in User.php
Change 470932 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix PHP warnings in User.php
Change 470940 merged by jenkins-bot:
[mediawiki/core@master] User: Don't fail mysteriously when passing a User object to idFromName()
Since this caused some train issues, pulling in for visibility to rest of team (and myself)
Hrm, I'm no longer seeing these errors in logstash, and I see that a couple patches are merged and at least 1 is backported to 1.33.0-wmf.2, does anything remain to be resolved? Still blocking further train rollout?
I'm not sure what there's left to review here. If the errors have disappeared from logstash, then this task can be resolved, right?
Per T208469#4713958.
Thanks to @Catrope for finding and fixing the bug and @Jdforrester-WMF for merging the fix(es).