Maniphest T208514

Merge PageIssues Feature Branch to Master
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

In T206178, we created a feature branch. Several other tasks have been worked on and need to be folded back into master.

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/467842/

This needs to be merged to master when the page issues code is shipped to production.

Precursors

T206178 resolved

QA steps

There should be no instrumentation code in the master branch (T206178)
Per T206179 it should be possible to turn on the new treatment of page issues for 100% users.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/MinervaNeue	master	+165 -582	Merge remote-tracking branch 'gerrit/page-issues-cleanup'

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Open	None	T65504 Consolidate code for MediaViewer across desktop and mobile (tracking)
Open	None	T162210 Upstream MobileFrontend components to core and other extensions (tracking)
Duplicate	Jdlrobson	T66316 [EPIC] Move Nearby code to more suitable extension
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core (replacing it with OOUI).
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Declined	None	T96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
Resolved	DannyH	T171973 Annual Plan 2017-2018, Audiences 3: Increase device support for editing
Open	None	T171974 Improve and consolidate our unified editing platform so that it's great on all devices
Open	None	T147641 [EPIC] Improve top of the article user experience - mobile
Resolved	Jdlrobson	T143535 [EPIC] Improve article notes
Resolved	ovasileva	T159262 [EPIC] Improve page issues
Duplicate	None	T101462 [EPIC] Merge OOJS UI library and Mobile unnamed library.
Open	marcella	T96186 [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
Open	None	T106267 mobile phone wikitext editor should have edit toolbar
Open	None	T106266 Provide a "signature" button in the mobile wikitext editor
Open	None	T159971 Provide the VE wikitext editing mode as the mobile wikitext editor
Resolved	matmarex	T198765 Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop)
Resolved	ABorbaWMF	T208514 Merge PageIssues Feature Branch to Master

Event Timeline

nray created this task.Nov 1 2018, 4:02 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptNov 1 2018, 4:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@ovasileva please let me know if this should be a subtask of T206178. Still getting the grasp of how phab should work

nray mentioned this in T206178: Feature branch: Remove pageIssues A-B test code.Nov 1 2018, 4:39 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.Nov 1 2018, 6:14 PM

Jdlrobson updated the task description. (Show Details)Nov 2 2018, 3:14 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Readers-Web-Backlog board.

ovasileva raised the priority of this task from Medium to High.Nov 2 2018, 5:33 PM

ovasileva added a parent task: T159262: [EPIC] Improve page issues.

gerritbot mentioned this in T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).Nov 6 2018, 7:19 PM

matmarex added a parent task: T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).Nov 6 2018, 7:20 PM

Change 472478 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] Merge remote-tracking branch 'gerrit/page-issues-cleanup'

https://gerrit.wikimedia.org/r/472478

gerritbot added a project: Patch-For-Review.Nov 8 2018, 3:34 PM

This is blocking my work on T198765. I hope you don't mind if I do this.

As far as I can tell, this can be done now, but if not, the commit can wait until it can.

Moving in for review!

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 8 2018, 5:58 PM

Jdlrobson mentioned this in T206179: Feature flag the page issues code.

async estimation.

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 9 2018, 12:59 AM

Change 472478 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Merge remote-tracking branch 'gerrit/page-issues-cleanup'

https://gerrit.wikimedia.org/r/472478

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 9 2018, 2:00 AM

@ABorbaWMF @Ryasmeen is it possible to get a general QA of page issues on https://reading-web-staging.wmflabs.org (old treatment only)?

Jdlrobson updated the task description. (Show Details)Nov 14 2018, 6:13 PM

ovasileva reassigned this task from Ryasmeen to ABorbaWMF.Nov 14 2018, 6:15 PM

It's looking ok to me. It is difficult to find pages with issues on staging but I was able to find a couple pages.

Thanks for testing @ABorbaWMF

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 15 2018, 4:51 PM

Merge PageIssues Feature Branch to MasterClosed, ResolvedPublic2 Estimated Story PointsActions