Page MenuHomePhabricator
Create Task
Maniphest T208547

Just clicking on the empty space around should not change the type of block radio button selection
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

I feel this is a bit inconvenient and has the risk of accidentally changing the block type. It's also inconsistent with other OOUIfied pages we have for example: Special:Preferences.

Seems like on Special:Block we are using oo-ui-radioSelectWidget but that's not the case with Special: Preferences?

Special:Block

Screen Shot 2018-11-01 at 2.21.46 PM.png (703×1 px, 163 KB)

Special:Preferences

Screen Shot 2018-11-01 at 2.21.18 PM.png (663×1 px, 169 KB)

Acceptance criteria

  • Clicking to the right of the radio button text (on LTR languages should not toggle the radio button
  • in other words... Only clicking the radio button (and its immediate hitbox) and the label text should toggle the radio button

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.31.4mediawiki/coremaster+523 -129
Remove full-width radio buttons to bring consistency with checkboxesoojs/uimaster+0 -1
Remove full-width radio buttons to bring consistency with checkboxesmediawiki/coremaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Nov 1 2018, 9:24 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 1 2018, 9:24 PM
• TBolliger moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 1 2018, 9:54 PM
dbarratt added a project: MediaWiki-User-management.Nov 2 2018, 1:04 AM
dbarratt subscribed.

I think this might be because the label is extending all the way to the right?

• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.Nov 2 2018, 4:15 PM
• TBolliger triaged this task as Low priority.Nov 2 2018, 4:22 PM

Appears that's the case, David. I understand we probably want the hitbox to be large enough for accessibility needs, but so far out seems unnecessary. Maybe we can fix with T202773: Update Special:Block to match the design ?

• TBolliger added a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 4:45 PM
dbarratt added a comment.Nov 2 2018, 5:13 PM
In T208547#4716313, @TBolliger wrote:

Appears that's the case, David. I understand we probably want the hitbox to be large enough for accessibility needs, but so far out seems unnecessary. Maybe we can fix with T202773: Update Special:Block to match the design ?

One could argue that it is acceptable the way it is, but the alternative would be to make it the width of the text (which I think is the default for most browsers which we are probably overriding somewhere).

• aezell subscribed.Nov 2 2018, 5:15 PM

I'd go with making it the width of the text.

• TBolliger added a comment.Nov 2 2018, 5:19 PM

That's how it works on Special:Preferences and I believe this is a standard interaction.

dbarratt removed a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:21 PM
dbarratt added a subtask: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:24 PM
• TBolliger updated the task description. (Show Details)Nov 15 2018, 6:07 PM
• TBolliger set the point value for this task to 2.Nov 15 2018, 7:54 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
• TBolliger reopened subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Open.Nov 19 2018, 9:50 PM
• TBolliger closed subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Resolved.Nov 19 2018, 10:00 PM
• TBolliger added a parent task: T214197: 👩‍👧‍👦 Parent task: MultiSelectWidget & Special:Block UI issues/enhancements/changes.Feb 13 2019, 9:56 PM
• TBolliger mentioned this in T213101: Add help text to Special:Block for Partial Blocks.Mar 4 2019, 5:17 PM
• Niharika moved this task from Cards ready for development to Zayin - ז on the Anti-Harassment board.Apr 3 2019, 10:52 PM
• Niharika edited projects, added Anti-Harassment (Zayin - ז); removed Anti-Harassment.
dbarratt claimed this task.Apr 4 2019, 3:26 PM
dbarratt moved this task from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
gerritbot added a comment.Apr 4 2019, 4:21 PM

Change 501349 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Remove full-width radio buttons to bring consistency with checkboxes

https://gerrit.wikimedia.org/r/501349

gerritbot added a project: Patch-For-Review.Apr 4 2019, 4:21 PM
dbarratt moved this task from In Progress to Review on the Anti-Harassment (Zayin - ז) board.Apr 4 2019, 4:22 PM
gerritbot added a comment.Apr 4 2019, 4:30 PM

Change 501349 abandoned by Dbarratt:
Remove full-width radio buttons to bring consistency with checkboxes

https://gerrit.wikimedia.org/r/501349

dbarratt moved this task from Review to In Progress on the Anti-Harassment (Zayin - ז) board.Apr 4 2019, 4:30 PM
gerritbot added a comment.Apr 4 2019, 4:36 PM

Change 501352 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[oojs/ui@master] Remove full-width radio buttons to bring consistency with checkboxes

https://gerrit.wikimedia.org/r/501352

dbarratt moved this task from In Progress to Review on the Anti-Harassment (Zayin - ז) board.Apr 4 2019, 4:37 PM
Jdforrester-WMF added a project: OOUI.Apr 4 2019, 6:58 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Apr 8 2019, 4:21 PM
• Niharika edited projects, added Anti-Harassment (Heth - ח); removed Anti-Harassment (Zayin - ז).Apr 10 2019, 6:43 PM
• Niharika moved this task from Ready to Review on the Anti-Harassment (Heth - ח) board.
gerritbot added a comment.Apr 16 2019, 10:25 PM

Change 501352 merged by jenkins-bot:
[oojs/ui@master] Remove full-width radio buttons to bring consistency with checkboxes

https://gerrit.wikimedia.org/r/501352

gerritbot added a comment.Apr 16 2019, 11:23 PM

Change 504473 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

gerritbot added a comment.Apr 17 2019, 5:09 AM

Change 504473 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

Volker_E moved this task from Reviewing to OOUI-0.31.4 on the OOUI board.Apr 17 2019, 5:18 AM
Volker_E edited projects, added OOUI (OOUI-0.31.4); removed OOUI.
Tchanders moved this task from Review to QA/Testing on the Anti-Harassment (Heth - ח) board.Apr 18 2019, 4:03 PM
dom_walden moved this task from QA/Testing to Done on the Anti-Harassment (Heth - ח) board.Apr 19 2019, 12:39 PM
dom_walden subscribed.

One line CSS change.

You now have to click on the radio button's label (or, from the user's perspective, the text associated with the radio button incl. the inline help text).

dbarratt closed this task as Resolved.Apr 19 2019, 4:12 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 19 2019, 4:12 PM
Volker_E removed a project: Patch-For-Review.Apr 27 2019, 7:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL