Maniphest T208558

Remove MFWatchlistRunsChangesListSpecialPageQuery and do not run ChangesListSpecialPageQuery
Closed, ResolvedPublic
Actions

Description

This task pays of some technical debt that was added to support a risky change.

In solving T206274 we dropped use of the ChangesListSpecialPageQuery hook.
The fix went into 1.32.0-wmf.26 which is now live on all wikis.

A feature flag was added to allow us to roll back in the event of a problem, but no problems have been encountered.

Acceptance criteria

MFWatchlistRunsChangesListSpecialPageQuery is removed from extension.json
SpecialMobileWatchlist doesn't run ChangesListSpecialPageQuery hook

Details

	Subject	Repo	Branch	Lines +/-
	Follow up on Ic0771804f245fcd8e696	mediawiki/extensions/MobileFrontend	master	+0 -16
	Remove MFWatchlistRunsChangesListSpecialPageQuery & remove related hook	mediawiki/extensions/MobileFrontend	master	+0 -13

Customize query in gerrit

Related Objects

Mentioned In: T206684: [spike, 1hrs] Verify that ChangesListSpecialPageQuery is not needed
Mentioned Here: T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

Event Timeline

Jdlrobson created this task.Nov 1 2018, 11:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2018, 11:56 PM

Paying off technical debt when low cost should be high IMO.

Jdlrobson mentioned this in T206684: [spike, 1hrs] Verify that ChangesListSpecialPageQuery is not needed.Nov 1 2018, 11:57 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.

Change 471220 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Remove MFWatchlistRunsChangesListSpecialPageQuery & don't run related hook

https://gerrit.wikimedia.org/r/471220

gerritbot added a project: Patch-For-Review.Nov 2 2018, 9:32 AM

xSavitar claimed this task.Nov 2 2018, 9:32 AM

xSavitar added a project: User-xSavitar.

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

xSavitar updated the task description. (Show Details)Nov 2 2018, 9:35 AM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.Nov 2 2018, 3:57 PM

Jdlrobson moved this task from To Do to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

xSavitar moved this task from Doing [WIP] to Completed (To be Resolved) on the User-xSavitar board.Nov 2 2018, 4:00 PM

Change 471220 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove MFWatchlistRunsChangesListSpecialPageQuery & remove related hook

https://gerrit.wikimedia.org/r/471220

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 2 2018, 5:01 PM

@D3r1ck01 I think some follow ups are needed here in includes/specials/SpecialMobileWatchlist.php.
It looks like SpecialMobileWatchList::getFormOptions and the line

$form_options = $this->getFormOptions();

can be removed.

Change 472206 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Follow up on Ic0771804f245fcd8e696

https://gerrit.wikimedia.org/r/472206

gerritbot added a project: Patch-For-Review.Nov 7 2018, 5:28 PM