Page MenuHomePhabricator
Create Task
Maniphest T208564

[Spike 4 hour] [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails
Open, MediumPublicSpike
Actions

Description

Steps to reproduce:

  1. Got to https://de.wikipedia.beta.wmflabs.org/wiki/SVG-Test
  2. The SVG uses no lang parameter, so since T205040: Show SVGs in page language if available it is shown in the content language, here in German.
  3. Click the image, wait until MMV has finished loading.

Expected: The image in MMV should be in German, too.
Actual: It's in English.

Related Objects

Event Timeline

Schnark created this task.Nov 2 2018, 7:50 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 2 2018, 7:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a project: I18n.Nov 2 2018, 10:58 AM
• Niharika added a project: Community-Tech.Nov 2 2018, 7:50 PM
• Niharika subscribed.

Good catch, @Schnark.

• Niharika renamed this task from MMV should show SVGs in language of the page, not English to [BUG] MMV should show SVGs in language of the page, not English.Nov 2 2018, 7:51 PM
• Niharika moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
Tgr closed this task as a duplicate of T60663: media viewer doesn't preserve thumbnail options like svg language.Nov 2 2018, 8:18 PM
Tgr renamed this task from [BUG] MMV should show SVGs in language of the page, not English to [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails.Nov 2 2018, 8:30 PM
Tgr reopened this task as Open.
Tgr subscribed.Nov 2 2018, 8:32 PM

Actually a different bug from T60663: media viewer doesn't preserve thumbnail options like svg language (which seems to have been fixed somewhere along the line, at least for SVGs) - the URL guessing provider (mmv.provider.GuessedThumbnailInfo.js) preserves the language but the API-based provider does not. So language detection would work in Wikimedia production but not on most other wikis.

Tgr mentioned this in T60663: media viewer doesn't preserve thumbnail options like svg language.Nov 2 2018, 8:36 PM
• Niharika renamed this task from [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails to [Spike 4 hour] [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails.Nov 21 2018, 12:50 AM
• Niharika moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.
MBinder_WMF added a project: Spike.Dec 11 2018, 12:48 AM
• jmatazzoni mentioned this in T93499: Add support for task types (subtypes).Feb 28 2019, 9:12 PM
• Niharika triaged this task as Medium priority.Jun 5 2019, 5:41 PM
• Niharika edited projects, added SVG Translate Tool; removed Community-Tech.
Restricted Application added a project: Community-Tech. · View Herald TranscriptJun 5 2019, 5:41 PM
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald Transcript
• Niharika removed a project: Community-Tech.Jun 12 2019, 6:47 PM
Tgr unsubscribed.Jul 9 2019, 6:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL