Page MenuHomePhabricator

[Spike 4 hour] [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails
Open, NormalPublicSpike

Description

Steps to reproduce:

  1. Got to https://de.wikipedia.beta.wmflabs.org/wiki/SVG-Test
  2. The SVG uses no lang parameter, so since T205040: Show SVGs in page language if available it is shown in the content language, here in German.
  3. Click the image, wait until MMV has finished loading.

Expected: The image in MMV should be in German, too.
Actual: It's in English.

Event Timeline

Schnark created this task.Nov 2 2018, 7:50 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 2 2018, 7:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Niharika added a subscriber: Niharika.

Good catch, @Schnark.

Niharika renamed this task from MMV should show SVGs in language of the page, not English to [BUG] MMV should show SVGs in language of the page, not English.Nov 2 2018, 7:51 PM
Niharika moved this task from Untriaged to To be estimated/discussed on the Community-Tech board.
Tgr renamed this task from [BUG] MMV should show SVGs in language of the page, not English to [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails.Nov 2 2018, 8:30 PM
Tgr reopened this task as Open.
Tgr added a subscriber: Tgr.Nov 2 2018, 8:32 PM

Actually a different bug from T60663: media viewer doesn't preserve thumbnail options like svg language (which seems to have been fixed somewhere along the line, at least for SVGs) - the URL guessing provider (mmv.provider.GuessedThumbnailInfo.js) preserves the language but the API-based provider does not. So language detection would work in Wikimedia production but not on most other wikis.

Niharika renamed this task from [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails to [Spike 4 hour] [BUG] MediaViewer ignores thumbnail options when using API provider for thumbnails.Nov 21 2018, 12:50 AM
Niharika moved this task from To be estimated/discussed to Estimated on the Community-Tech board.
Niharika triaged this task as Normal priority.Jun 5 2019, 5:41 PM
Niharika edited projects, added SVG Translate Tool; removed Community-Tech.
Restricted Application added a project: Community-Tech. · View Herald TranscriptJun 5 2019, 5:41 PM
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald Transcript
Tgr removed a subscriber: Tgr.Jul 9 2019, 6:02 PM