Page MenuHomePhabricator
Create Task
Maniphest T208596

Action buttons in link context menu are mispositioned
Closed, ResolvedPublic
Actions

Description

Action buttons in link context menu are mispositioned.

image.png (568×1 px, 211 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (a5db6fb8b)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.LinearContextItem: Prevent action buttons from wrappingVisualEditor/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Nov 2 2018, 3:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2018, 3:13 PM
matmarex claimed this task.Nov 2 2018, 3:13 PM

Caused by style changes in new OOUI.

gerritbot subscribed.Nov 2 2018, 3:29 PM

Change 471270 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.LinearContextItem: Prevent action buttons from wrapping

https://gerrit.wikimedia.org/r/471270

gerritbot added a project: Patch-For-Review.Nov 2 2018, 3:29 PM
Jdforrester-WMF edited projects, added VisualEditor-EditingTools, VisualEditor (Current work); removed Patch-For-Review, VisualEditor.Nov 2 2018, 4:40 PM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 2 2018, 4:42 PM

Change 471270 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.LinearContextItem: Prevent action buttons from wrapping

https://gerrit.wikimedia.org/r/471270

matmarex mentioned this in T208516: CX2: Link card UI regressions.Nov 5 2018, 6:49 PM
matmarex mentioned this in T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons.Nov 5 2018, 6:51 PM
gerritbot added a comment.Nov 5 2018, 7:50 PM

Change 471791 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5db6fb8b)

https://gerrit.wikimedia.org/r/471791

gerritbot added a project: Patch-For-Review.Nov 5 2018, 7:50 PM
gerritbot added a comment.Nov 5 2018, 9:56 PM

Change 471791 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5db6fb8b)

https://gerrit.wikimedia.org/r/471791

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.3; 2018-11-06); removed Patch-For-Review.Nov 5 2018, 9:56 PM
Ryasmeen added a project: Verified.Nov 6 2018, 1:05 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.4; 2018-11-13); removed MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 6 2018, 7:03 PM
• marcella closed this task as Resolved.Nov 19 2018, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL