Maniphest T208620

Parsoid should support multilingual SVG thumbnails in page language
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Nov 2 2018, 7:51 PM

Description

This support was added to core in T205040 (I348840ef405e1370cc0c17d69051bce30153c9c0) and needs to be ported to Parsoid. Parsertests for this feature were added to the blacklist in Ic4e77a06638770e7439edcce1572bfe26f5838ad

Copied from duplicate T247671

Steps to Reproduce:
Edit https://de.wikipedia.org/w/index.php?title=COVID-19&direction=prev&oldid=197763810#Vorbeugung with 2017-wikitext-editor

Image from https://commons.wikimedia.org/w/index.php?title=File:COVID-19_Health_care_limit.svg&lang=de

If I use a image such as [[File:COVID-19_Health_care_limit.svg|mini|lang=de|description]] it shows the image in the default language (e.g. english) not in German (de). As soon as I save the page it is in German. Since I create multilingual svgs, I would like to check them before using in articles.

This image is used here:

https://de.wikipedia.org/w/index.php?title=COVID-19&direction=prev&oldid=197763810#Vorbeugung

Actual Results:
dispays the image with the default language (english)

220px-COVID-19_Health_care_limit.svg.png (103×220 px, 5 KB)

Expected Results:
display the image in German (lang=de)

langde-220px-COVID-19_Health_care_limit.svg2.png (103×220 px, 5 KB)

Details

Project	Branch	Lines +/-	Subject
mediawiki/vendor	master	+25 K -2 K	Bump wikimedia/parsoid to 0.16.0-a1
mediawiki/core	master	+7 -0	Use badfilecontexttitle to set targetlang for imageinfo requests
mediawiki/services/parsoid	master	+61 -12	Add html/parsoid sections for svg rendering by page language tests
mediawiki/services/parsoid	master	+8 -2	Support rendering SVG based on page language
mediawiki/vendor	master	+513 -287	Bump wikimedia/parsoid to 0.15.0-a18
mediawiki/services/parsoid	master	+72 -40	Support lang= option for SVGs

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Arlolra	T269422 Parsoid HTML doesn't show localized SVG thumbnails
		Resolved		Arlolra	T208620 Parsoid should support multilingual SVG thumbnails in page language

Event Timeline

cscott created this task.Nov 2 2018, 7:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2018, 7:51 PM

I'll try to work on this.

Shreyasminocha triaged this task as Medium priority.Nov 29 2018, 4:42 PM

Starting points, copied from IRC:

the first step would be to do some research: look at the patch that was landed to enable this support in the core parser (linked from T205040)
figure out what the filenames for the language-specific svg thumbnails look like (there's an example in the phabricator task comments, but you should verify against the code)
then look at the info returned by the imageinfo API request to see if the required information is present
assuming it is, you'd then (1) add code to tokenize/parse the "lang" option (this might already be present)
(2) tweak the parsoid code which does the imageinfo request to pass along the language; hopefully this will return the right thumbnail URLs from core
(3) check that the parsertests for this feature now pass and/or add new tests (or new parsoid-specific test output for existing tests)
on the parsoid side, all the code you'd need to alter should be in lib/mw/ApiRequest.js lib/mw/Batcher.js lib/wt2html/tt/LinkHandler.js and tests/mockAPI.js:
if you don't already know about https://en.wikipedia.org/wiki/Special:ApiSandbox it will probably be very helpful
https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&format=json&prop=imageinfo&titles=File%3AAlbert%20Einstein%20Head.jpg&iiprop=url%7Cmediatype%7Cmime%7Csize&iiurlwidth=200
is an example imageinfo request that returns thumbnail urls
so the goal would be to tweak that request (as made by parsoid) to return the proper language-specific thumbnail urls

takidelfin awarded a token.Dec 9 2018, 3:43 PM

takidelfin added a subscriber: takidelfin.

LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM

JoKalliauer mentioned this in T247671: 2017 wikitext editor: multilingual SVG not rendered in content language.Mar 14 2020, 11:09 PM

ssastry moved this task from Backlog to Missing Functionality on the Parsoid board.Mar 15 2020, 12:57 AM

ssastry merged a task: T247671: 2017 wikitext editor: multilingual SVG not rendered in content language.

ssastry added subscribers: JoKalliauer, TheDJ, ssastry.

I'm sorry that I never got around to working on this.

JoKalliauer renamed this task from Parsoid should support SVG thumbnails in page language to Parsoid should support multilingual SVG thumbnails in page language.Mar 15 2020, 6:25 AM

JoKalliauer added projects: VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, Page-Previews (Tracking).

JoKalliauer updated the task description. (Show Details)

matej_suchanek mentioned this in T269422: Parsoid HTML doesn't show localized SVG thumbnails.Dec 4 2020, 10:43 AM

Aklapper added a parent task: T269422: Parsoid HTML doesn't show localized SVG thumbnails.Jan 19 2021, 9:26 AM

• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Feb 11 2021, 4:54 PM

• ppelberg added a project: Editing-team (Tracking).

• ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.

Arlolra added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).Jan 26 2022, 1:00 AM

Arlolra claimed this task.Jan 26 2022, 1:06 AM

Change 757520 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Support lang= option for SVGs

https://gerrit.wikimedia.org/r/757520

gerritbot added a project: Patch-For-Review.Jan 26 2022, 8:15 PM

Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jan 26 2022, 9:29 PM

Change 757980 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Support rendering SVG based on page language

https://gerrit.wikimedia.org/r/757980

Change 757520 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Support lang= option for SVGs

https://gerrit.wikimedia.org/r/757520

Change 758585 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a18

https://gerrit.wikimedia.org/r/758585

Change 758585 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a18

https://gerrit.wikimedia.org/r/758585

Parsoid now respects the lang= option,
https://de.wikipedia.org/api/rest_v1/page/html/COVID-19/197763810#Vorbeugung

However, T205040 is also about falling back the page language which is still to be done.

Change 770627 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Use badfilecontexttitle to set targetlang for imageinfo requests

https://gerrit.wikimedia.org/r/770627

Change 771079 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add html/parsoid sections for svg rendering by page language tests

https://gerrit.wikimedia.org/r/771079

Change 757980 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Support rendering SVG based on page language

https://gerrit.wikimedia.org/r/757980

Change 771079 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add html/parsoid sections for svg rendering by page language tests

https://gerrit.wikimedia.org/r/771079

Arlolra closed this task as Resolved.Mar 16 2022, 3:08 PM

Change 770627 merged by jenkins-bot:

[mediawiki/core@master] Use badfilecontexttitle to set targetlang for imageinfo requests

https://gerrit.wikimedia.org/r/770627

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 17 2022, 3:00 AM

Change 772510 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a1

https://gerrit.wikimedia.org/r/772510

Change 772510 merged by jenkins-bot: