Maniphest T208627

TitlesMultiselectWidget for Partial blocks suggests and accepts for more pages than the maximum
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• TBolliger
	Nov 2 2018, 8:56 PM

Description

Problem: The 'Pages' text input box suggests and accepts for 11 or more pages, when the maximum is 10. These are rejected on submission, but this is bad design.

Acceptance criteria

The error messages should continue to appear if the admin somehow manages to get these through
The 'Pages' input field should not suggest more than 10 pages
The 'Pages' input field should not accept more than 10 pages

Note that we may adjust the maximum value in the future: T202776: Determine then implement page limit for partial blocks

Notes: TagMultiSelect should have a limit. Needs to be fixed in upstream OOUI.

Details

Subject	Repo	Branch	Lines +/-
TitlesMultiselectWidget: pass through additional configs	mediawiki/core	master	+25 -0
Update OOUI to v0.29.4	mediawiki/core	master	+336 -58
TagMultiSelectWidget: Add a 'limit' configuration option	oojs/ui	master	+84 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Tchanders	T208627 TitlesMultiselectWidget for Partial blocks suggests and accepts for more pages than the maximum
		Resolved		dmaza	T203821 After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org

Event Timeline

• TBolliger created this task.Nov 2 2018, 8:56 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 2 2018, 8:56 PM

• TBolliger assigned this task to Mooeypoo.Nov 2 2018, 8:56 PM

• TBolliger triaged this task as Medium priority.

• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.

• TBolliger moved this task from Snackbox to Tracking work by others on the Anti-Harassment board.Nov 2 2018, 8:59 PM

• TBolliger added a subtask: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.

• TBolliger moved this task from Tracking work by others to Snackbox on the Anti-Harassment board.Nov 2 2018, 9:02 PM

Change 471364 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] TagMultiSelectWidget: Add a 'limit' configuration option

https://gerrit.wikimedia.org/r/471364

gerritbot added a project: Patch-For-Review.Nov 2 2018, 11:44 PM

Mooeypoo moved this task from Backlog to Doing on the OOUI board.Nov 2 2018, 11:56 PM

Mooeypoo edited projects, added Anti-Harassment (AHT Sprint 32); removed Anti-Harassment.

Mooeypoo moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 32) board.

Change 471364 merged by jenkins-bot:
[oojs/ui@master] TagMultiSelectWidget: Add a 'limit' configuration option

https://gerrit.wikimedia.org/r/471364

Library part of this done; once it's pulled through (in a couple of hours' time) we'll just need to configure the limit value.

Jdforrester-WMF edited projects, added OOUI (OOUI-0.29.4); removed Patch-For-Review, OOUI.Nov 6 2018, 8:35 PM

Change 472080 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

gerritbot added a project: Patch-For-Review.Nov 7 2018, 1:03 AM

Change 472080 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 2:00 AM

• Petar.petkovic removed a project: Patch-For-Review.Nov 7 2018, 8:11 AM

• TBolliger updated the task description. (Show Details)Nov 7 2018, 6:20 PM

• TBolliger moved this task from AHT Sprint 32 to AHT Sprint 33 on the Anti-Harassment board.Nov 8 2018, 8:03 PM

• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment (AHT Sprint 32).

• TBolliger moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 33) board.

dbarratt claimed this task.Nov 9 2018, 12:50 AM

dbarratt moved this task from Review to In progress on the Anti-Harassment (AHT Sprint 33) board.

dbarratt added a subscriber: Mooeypoo.

The 'limit' value (renamed 'tagLimit' in T209057) is passed through in the patch on T208626.

Change 472451 had a related patch set uploaded (by Dbarratt; owner: Tchanders):
[mediawiki/core@master] TitlesMultiselectWidget: pass through additional configs

https://gerrit.wikimedia.org/r/472451

gerritbot added a project: Patch-For-Review.Nov 9 2018, 3:41 PM

dbarratt reassigned this task from dbarratt to Tchanders.Nov 9 2018, 3:41 PM

dbarratt moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.

dbarratt subscribed.

Change 472451 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] TitlesMultiselectWidget: pass through additional configs

https://gerrit.wikimedia.org/r/472451

Change 472451 merged by jenkins-bot:
[mediawiki/core@master] TitlesMultiselectWidget: pass through additional configs

https://gerrit.wikimedia.org/r/472451

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 13 2018, 9:00 PM

Tchanders moved this task from Review to Done on the Anti-Harassment (AHT Sprint 33) board.Nov 14 2018, 3:59 PM

dbarratt closed this task as Resolved.Nov 14 2018, 7:55 PM

• TBolliger reopened subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Open.Nov 19 2018, 9:49 PM

• TBolliger closed subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Resolved.Nov 19 2018, 10:00 PM