Maniphest T208648

WTE2017 loads in both visual and WT mode after removal of a section and the section you try to edit is the last one
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Izno
	Nov 3 2018, 3:06 PM

Description

I used WTE2017 to remove a section in the page. I saw an opportunity for a followup edit, which was to change some of the links in the External links section. When I went to make an edit in that section, I got the below (representative, not actual) error.

For some reason I decided to retry by pressing OK rather than refreshing. The page reloaded in edit mode. The mode listed in the edit toolbar was source editing. What was displayed however, was VE mode:

I scrolled to the bottom of the page. What displayed at the bottom was a hybrid of visual and source editing (you might note that source highlighting is turned on; I doubt that's the problem here).

The "External links" section appears twice, once in visual and once in source mode. Since it's a wiki, I made my change and hit Publish and got:

I think this is (possibly) because the underlying HTML hasn't been changed after the page is successfully edited (for whatever reason that I do not know). Refreshing the page here can workaround the issue. There should probably be, or is, a bug for remembering the previous state of the page.

Reproduction of the error I bumped into probably requires a page with multiple sections, removing at least one which is not the last, then trying to edit the last, without attempting to refresh the page at any time.

This was on Firefox 63.0 on Windows 10.

Event Timeline

Izno created this task.Nov 3 2018, 3:06 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 3 2018, 3:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Izno updated the task description. (Show Details)Nov 3 2018, 3:12 PM

Izno updated the task description. (Show Details)Nov 3 2018, 3:36 PM

We will investigate this ticket

JTannerWMF moved this task from FY 18-19 Q3/Q4 to Up next on the VisualEditor board.Jan 16 2019, 6:57 PM

I can reproduce the error message from the first screenshot easily, by just putting in a section number larger than the actual count of sections, e.g. https://en.wikipedia.org/wiki/The_Fighting_Temeraire?veaction=editsource&section=100.

But I can't reproduce the other issues. I don't know if we fixed it, or if you did something special that actually causes additional problems.

For me, clicking "OK" just causes the dialog to appear again. Clicking "Cancel" leads to https://en.wikipedia.org/wiki/The_Fighting_Temeraire?action=edit&section=100&veswitched=1, which would normally show the old wikitext editor, but here it just shows a slightly different error message that also says there's no section.

For some reason I decided to retry by pressing OK rather than refreshing. The page reloaded in edit mode. The mode listed in the edit toolbar was source editing. What was displayed however, was VE mode:
…
I scrolled to the bottom of the page. What displayed at the bottom was a hybrid of visual and source editing (you might note that source highlighting is turned on; I doubt that's the problem here).

Actually, what we're seeing in the screenshots is the read mode, not VE mode – the read mode has section edit links, the VE mode doesn't.

matmarex changed the task status from Open to Stalled.Jul 30 2019, 7:03 PM

In recent Chrome and Firefox, cannot reproduce the beginning of the chain as I laid out in the original task actually. Trying your way, I cannot reproduce this issue either. I'd put this down to browser version or fixed elsewhere since.

In T208648#5377536, @matmarex wrote:

I scrolled to the bottom of the page. What displayed at the bottom was a hybrid of visual and source editing (you might note that source highlighting is turned on; I doubt that's the problem here).

Actually, what we're seeing in the screenshots is the read mode, not VE mode – the read mode has section edit links, the VE mode doesn't.

Yes, that's true, for the portion of the display that was this view.

Closing resolved accordingly. Feel free to pick another status if that's not suitable.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 5 2019, 8:41 PM

WTE2017 loads in both visual and WT mode after removal of a section and the section you try to edit is the last oneClosed, ResolvedPublicActions

Description

Event Timeline

WTE2017 loads in both visual and WT mode after removal of a section and the section you try to edit is the last one
Closed, ResolvedPublic
Actions