Page MenuHomePhabricator
Create Task
Maniphest T208659

Squash TicketWatcher and TopicWatcher models
Closed, ResolvedPublic
Actions

Description

Currently, we have two models that are watchable (Ticket and Topic). Who watches what is stored in TicketWatcher/TopicWatcher models.

For easier extending of notifications to other objects (like Grants or even whole objects) having single Watcher model (with "type" attribute) would be useful, so making an object watchable wouldn't mean to add new database tables.

This should include a data migration to migrate data from TicketWatcher and TopicWatcher to the new model.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Squash Watcher classes into single classwikimedia-cz/trackermaster+112 -32
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Nov 3 2018, 8:17 PM
Urbanecm added a project: good first task.Nov 11 2018, 10:31 PM
Urbanecm renamed this task from Squash TicketWatcher and TopicWatcher classes to Squash TicketWatcher and TopicWatcher models.Nov 12 2018, 9:04 AM
Urbanecm triaged this task as Low priority.
Urbanecm edited projects, added Google-Code-in-2018, User-Urbanecm; removed good first task.
Urbanecm updated the task description. (Show Details)
Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Nov 12 2018, 9:14 AM
Urbanecm moved this task from Backlog to GCI on the User-Urbanecm board.
Urbanecm moved this task from Inbox to GCI on the WMCZ-Tracker board.
Urbanecm mentioned this in T208656: Allow topic admins/ticket owners to override watching set up by system.Nov 12 2018, 9:18 AM
Arcayn claimed this task.Nov 12 2018, 8:18 PM
gerritbot subscribed.Nov 13 2018, 8:27 PM

Change 473277 had a related patch set uploaded (by Arcayn; owner: Arcayn):
[wikimedia-cz/tracker@master] Squash Watcher classes into single class

https://gerrit.wikimedia.org/r/473277

gerritbot added a project: Patch-For-Review.Nov 13 2018, 8:27 PM
gerritbot added a comment.Nov 14 2018, 9:00 PM

Change 473277 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Squash Watcher classes into single class

https://gerrit.wikimedia.org/r/473277

Urbanecm closed this task as Resolved.Nov 14 2018, 9:11 PM
Urbanecm mentioned this in T209538: Allow users to watch grants.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits