Page MenuHomePhabricator
Create Task
Maniphest T208670

Parameter must be an array or an object that implements Countable
Closed, ResolvedPublic
Actions

Description

Warning: count(): Parameter must be an array or an object that implements Countable in mediawiki/extensions/PageForms/includes/forminputs/PF_TextWithAutocompleteInput.php on line 145

In PHP7.2 null isn't countable any more.

Details

SubjectRepoBranchLines +/-
Return empty array for autocomplete values with no sourcemediawiki/extensions/PageFormsmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Nov 4 2018, 8:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2018, 8:37 AM
gerritbot subscribed.Nov 4 2018, 8:41 AM

Change 471535 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/PageForms@master] Return empty array for autocomplete values with no source

https://gerrit.wikimedia.org/r/471535

gerritbot added a project: Patch-For-Review.Nov 4 2018, 8:41 AM
Samwilson mentioned this in rEPFM28c9910cf8c6: Return empty array for autocomplete values with no source.Nov 4 2018, 8:41 AM
Samwilson mentioned this in rEPFM4ff4c1097400: Return empty array for autocomplete values with no source.Nov 4 2018, 8:51 AM
CCicalese_WMF moved this task from Untriaged to Other on the PHP 7.2 support board.Nov 6 2018, 4:08 AM
Yaron_Koren mentioned this in rEPFMa358c1548feb: Return empty array for autocomplete values with no source.Nov 21 2018, 2:21 AM
gerritbot added a comment.Nov 21 2018, 2:24 AM

Change 471535 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Return empty array for autocomplete values with no source

https://gerrit.wikimedia.org/r/471535

Yaron_Koren closed this task as Resolved.Nov 21 2018, 2:33 AM
Yaron_Koren claimed this task.
Yaron_Koren subscribed.

Thanks for the patch, and sorry for the delay!

Samwilson added a comment.Nov 21 2018, 2:34 AM

No worries! :) Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL