Page MenuHomePhabricator
Create Task
Maniphest T208680

Split preferences from TrackerProfile model to simplify preferences logic
Closed, ResolvedPublic
Actions

Description

Currently, you need to add new preference value to several places. It would be nice if new preference is needed only in preferences model (for storing purposes only). This can be done by creating dedicated model TrackerPreferences (or something like that) and modifying the preferences logic.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Split preferences from TrackerProfilewikimedia-cz/trackermaster+106 -25
Customize query in gerrit

Event Timeline

Urbanecm created this task.Nov 4 2018, 3:11 PM
Urbanecm added projects: Google-Code-in-2018, User-Urbanecm.Nov 4 2018, 4:59 PM
Urbanecm updated the task description. (Show Details)
Urbanecm moved this task from Backlog to GCI on the User-Urbanecm board.
Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

I imported this as https://codein.withgoogle.com/tasks/4974179053993984/ and will mentor it.

Urbanecm moved this task from Inbox to Working on on the WMCZ-Tracker board.Nov 4 2018, 5:18 PM
Urbanecm moved this task from Working on to GCI on the WMCZ-Tracker board.Nov 5 2018, 7:43 PM
Arcayn claimed this task.Nov 10 2018, 8:07 AM
Arcayn triaged this task as Medium priority.
gerritbot subscribed.Nov 10 2018, 12:06 PM

Change 472777 had a related patch set uploaded (by Arcayn; owner: Arcayn):
[wikimedia-cz/tracker@master] Split preferences from TrackerProfile

https://gerrit.wikimedia.org/r/472777

gerritbot added a project: Patch-For-Review.Nov 10 2018, 12:07 PM
gerritbot added a comment.Nov 11 2018, 6:36 PM

Change 472777 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Split preferences from TrackerProfile

https://gerrit.wikimedia.org/r/472777

Urbanecm closed this task as Resolved.Nov 11 2018, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits