Page MenuHomePhabricator

Remove suggestions which fail to add a link
Closed, ResolvedPublic

Description

When the queue is left sitting for a few months, a significant portion of the suggestions results in "No edit was made". Often it's because the citation was removed or edited independently, sometimes it's people acting on the suggestion outside the tool (I run into one case or two by Josve05a).

This annoys users, as shown by T178979 and T180672, and is a problem for at least three reasons:

  • some time is wasted looking at suggestions which are no longer relevant;
  • instead of loading a new suggestion right away, the warning requires that you click the button again;
  • stale suggestions inflate the queue, making it harder to tell how many "real" suggestions are left.

Event Timeline

Ideally we would check the edit just before it's proposed to the user, and move on to another edit (deleting the suggestion) if it's no longer valid, but this could add quite an overhead to the time taken to load the edit - especially if the tool has to go through a number of suggestions before it's able to find a valid one. We could instead have a background process running through all the cached edits and ensuring each gets checked on a regular basis, deleting suggestions that are no longer valid, but that doesn't 100% solve the problem because we're not checking at the time the edit is proposed.

Nemo_bis claimed this task.