Page MenuHomePhabricator
Create Task
Maniphest T208720

Template parameter alias "pills" vertically truncated [regression]
Closed, ResolvedPublic
Actions

Description

image.png (303×457 px, 32 KB)

The border should be visible on all sides of "film_name"

Details

SubjectRepoBranchLines +/-
Fix padding around .ve-ui-mwParameterResultWidget-name(s)mediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Nov 5 2018, 11:48 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 5 2018, 11:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders renamed this task from Template parameter alias "pills" vertically truncated to Template parameter alias "pills" vertically truncated [regression].Nov 5 2018, 11:48 AM
Esanders added a project: Regression.
gerritbot subscribed.Nov 5 2018, 11:51 AM

Change 471700 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix padding around .ve-ui-mwParameterResultWidget-name(s)

https://gerrit.wikimedia.org/r/471700

gerritbot added a project: Patch-For-Review.Nov 5 2018, 11:51 AM
Esanders added a comment.Nov 5 2018, 11:51 AM

After:

image.png (342×462 px, 33 KB)

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 5 2018, 11:52 AM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
Jdforrester-WMF assigned this task to Esanders.Nov 5 2018, 4:40 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 5 2018, 6:27 PM

Change 471700 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix padding around .ve-ui-mwParameterResultWidget-name(s)

https://gerrit.wikimedia.org/r/471700

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 5 2018, 7:01 PM
JTannerWMF added a project: Editing QA.Nov 6 2018, 5:27 PM
Ryasmeen subscribed.Nov 8 2018, 10:23 PM
In T208720#4719890, @Esanders wrote:

After:

image.png (342×462 px, 33 KB)

What template is this?

Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Nov 8 2018, 10:26 PM
JTannerWMF moved this task from Inbox to Low Priority on the Editing QA board.Nov 14 2018, 4:23 PM
matmarex moved this task from Stalled/Waiting to QA on the VisualEditor (Current work) board.Nov 14 2018, 4:27 PM
matmarex subscribed.

What template is this?

Looks like https://en.wikipedia.org/wiki/Template:Infobox_film

Ryasmeen added a comment.Nov 14 2018, 10:48 PM
In T208720#4746932, @matmarex wrote:

What template is this?

Looks like https://en.wikipedia.org/wiki/Template:Infobox_film

Thanks.

Ryasmeen edited projects, added Verified; removed Editing QA.Nov 14 2018, 10:48 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• marcella closed this task as Resolved.Nov 19 2018, 7:24 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 19 2018, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits