Page MenuHomePhabricator
Create Task
Maniphest T208732

[regression] Template diff messages broken
Closed, ResolvedPublic
Actions

Description

View any visual diff involving template params

image.png (184×244 px, 9 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWTransclusionNode: Change HTML messages to plain DOMmediawiki/extensions/VisualEditormaster+15 -9
Customize query in gerrit

Event Timeline

Esanders created this task.Nov 5 2018, 3:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2018, 3:17 PM
Esanders triaged this task as High priority.Nov 5 2018, 3:18 PM
gerritbot subscribed.Nov 5 2018, 3:18 PM

Change 471743 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWTransclusionNode: Fix HTML message check

https://gerrit.wikimedia.org/r/471743

gerritbot added a project: Patch-For-Review.Nov 5 2018, 3:18 PM
Esanders added a comment.Nov 5 2018, 3:19 PM

After:

image.png (100×238 px, 5 KB)

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 5 2018, 3:19 PM
Esanders updated the task description. (Show Details)
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 5 2018, 10:31 PM
gerritbot added a comment.Nov 5 2018, 10:45 PM

Change 471743 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTransclusionNode: Change HTML messages to plain DOM

https://gerrit.wikimedia.org/r/471743

Jdforrester-WMF removed a project: Patch-For-Review.Nov 5 2018, 10:58 PM
JTannerWMF added a project: Editing QA.Nov 6 2018, 5:26 PM
Esanders claimed this task.Nov 6 2018, 5:28 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 7:03 PM
JTannerWMF moved this task from Inbox to Low Priority on the Editing QA board.Nov 7 2018, 11:13 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Nov 8 2018, 10:32 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• marcella closed this task as Resolved.Nov 19 2018, 7:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits