Page MenuHomePhabricator
Create Task
Maniphest T208761

[Epic] Improve PHPUnit coverage in MobileFrontend to 50%
Closed, DeclinedPublic
Actions

Description

MobileFrontend's PHP code coverage is currently very low (at time of writing this ticket, it is 27% (and low!)

See:
https://doc.wikimedia.org/cover-extensions/MobileFrontend/

We would like to improve things here, with a target of at least 50% as a starting point.

Suggested focus errors

  • Remove redundant code
  • write tests for the Amc folder
  • write tests for MobileFrontendHooks.php

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenFeatureNoneT40891 MediaWiki API 2.0 (tracking)
 Resolved• JdlrobsonT95741 API: Inconsistent response for empty collections
 DeclinedNoneT208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
 DeclinedNoneT145219 [EPIC] Cleanup MobileFormatter and MobileViewAPI where they overlap
 DuplicateNoneT109461 [EPIC]: Improvements to mobileview API
 Resolved• nrayT86210 MobileFrontend throws away warnings and other data from action=parse
 ResolvedphuedxT69054 API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output
 ResolvedAnomieT12887 API JSON formatter returns [] as an empty return value - inconsistent with {} for non-empty values
 ResolvedAnomieT76728 Clean up ApiResult and ApiFormatXml, create new formatversion
 ResolvedAnomieT85236 Better unit testing for ApiFormat*
 ResolvedEBernhardsonT90745 Flow ApiFlowModerateTopicTest::testModerateTopic() assumes ApiResult will pass through arbitrary objects
 ResolvedAnomieT98083 add checkbox to ApiSandbox to use formatversion=2
 ResolvedAnomieT98086 improve RELEASE-NOTES-1.25 for formatversion=2 change
 OpenNoneT212069 API action=wbgetentities does not handle formatversion=2
 DuplicateNoneT78479 API error messages should be localised
 ResolvedNoneT98528 mobileview "thumbwidth" parameter doesn't always result in return of desired image url for SVG files
 ResolvedphuedxT156408 Create interface between Skin and MobileFormatter
 DeclinedNoneT146396 Improve performance of mobile references API
 OpenNoneT143189 [EPIC] Split MobileContext god object apart
 ResolvedphuedxT143875 Allow the MobileContext class to be broken apart by creating the MobileContext service
 ResolvedphuedxT143891 Make MobileContext modular by creating the DeviceDetector service
 DeclinedNoneT144085 Make MobileContext modular by creating the Blacklist service
 OpenSpikeNoneT212802 [Spike, 12hrs] How do we extract beta / stable mode code from MobileContext to new file?
 DeclinedNoneT218244 [Tracking] Migrate MobileContext::singleton() to a MobileFrontend.Context service
 ResolvedAmmarpadT261804 Technical: Drop getContentTransformations and setContentTransformations in MobileContext
 ResolvedxSavitarT208797 PHPUnit: Cover all includes/MobileUI.php class methods
 ResolvedxSavitarT208987 PHPUnit: Cover all model/MobileCollection class methods
 ResolvedxSavitarT209218 PHPUnit: Cover all scenarios for WMFBaseDomainExtractor class
 ResolvedxSavitarT209476 PHPUnit: Cover some model/MobilePage class methods
 ResolvedpmiazgaT209768 Fix $this->file hard dependency on PageImages extension
 OpenNoneT209477 PHPUnit: Cover 2 methods in MobileFrontend.body.php
 ResolvedxSavitarT209713 PHPUnit: Cover all features/Feature class methods
 ResolvedNoneT209765 PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class
 ResolvedxSavitarT210333 PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests
 ResolvedNoneT210390 PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests
 ResolvedphuedxT210400 PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests
 ResolvedpmiazgaT212666 PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests
 OpenNoneT214800 PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php
 ResolvedSpikeovasilevaT261805 [spike, 4hrs] Review and possibly remove the unused SubHeadingTransform transform
 Resolved• JdlrobsonT186627 Remove the MobileView API
 DeclinedNoneT99009 Remove noimages transform (was inconsistent parameter names for action=mobileview when you compare with action=parse)
 OpenNoneT43716 [EPIC] Support language variant conversion in Parsoid
 OpenNoneT21044 Document LanguageConverter
 OpenNoneT53587 Parsoid needs to run findVariantLink or some equivalent thing
 Invalid• GWickeT48658 Tpl-style encapsulation for <*include*> and lang-variant conversions
 ResolvedliangentT45547 MediaWiki needs a fictitious variant for English for easier variant development work
 ResolvedthiemowmdeT156280 WikiBase assumes English doesn't have a variant
 OpenNoneT54661 Preprocessor/Parser irregularities with -{...}- variant constructs.
 ResolvedcscottT146304 Preprocessor should handle -{...}- variant constructs in template arguments
 ResolvedcscottT153761 Incorrect parser output if -{{ appears in wikitext
 ResolvedElitreT165175 Support communications around the preprocessor fixups
 ResolvedcscottT146305 Parser should protect -{...}- variant constructs in links
 ResolvedcscottT54192 Markups in alt param of <gallery> are "eaten" during parsing
 ResolvedcscottT54190 <gallery> with |link=<external link> doesn't work on wikis with LanguageConverter
 ResolvedcscottT153135 doBlockLevels breaks with embedded language converter markup
 ResolvedcscottT153140 -{ ... }- markup breaks tables
 OpenNoneT153265 Language converter source text and language names cannot use <nowiki> escaping.
 ResolvedcscottT153341 Export LanguageConverter enabled status in page info from core
 OpenNoneT204966 Production use of LanguageConverter for read views of Phase 2A languages
 OpenNoneT204968 Production use of LanguageConverter for read views of Phase 2B languages
 OpenNoneT204969 Production use of LanguageConverter for read views of Phase 2C languages
 OpenNoneT222328 [extlink] parsing - link cannot contain language variant or extension tags
 ResolvedBUG REPORTJgiannelosT305383 [BUG] Kazakh Wikipedia Character mapping
 OpenNoneT320733 Support and document how language conversion work with multidirectional wikitext <=> HTML conversion on language-conversion-supported extensions.
 DeclinedNoneT173379 Remove mobileview API call for main page
 Resolved• JdlrobsonT32405 [EPIC] MobileFrontend extension should stop special-casing main page
 Resolved• JdlrobsonT138425 wgMFSpecialCaseMainPage should be disabled on new wiki installs
 DuplicateNoneT138449 Throw warning when edits made to a main page which uses special casing
 DuplicateNoneT138622 Help community migrate away from legacy Main page special casing
 ResolvedTgrT133410 Deploy TemplateStyles to WMF production
 ResolvedAnomieT133414 Deploy TemplateStyles to the beta-cluster
 ResolvedtstarlingT133408 Security review of TemplateStyles
 ResolvedcorenT133409 Complete initial version of TemplateStyles sufficient to do security review and then deploy it to WMF production
 ResolvedAnomieT135788 TemplateStyles should support media queries
 DeclinedBUG REPORTNoneT138343 [BUG] Certain Articles can Scroll Left & Right
 ResolvedAnomieT136054 TemplateStyles puts css in page_props table, which might be subject to race conditions, etc
 ResolvedEsandersT164790 Add class mw-parser-output to VE's editing area
 ResolvedEsandersT164791 Add class mw-parser-output to Flow comment- or content- containing elements
 ResolvedssastryT164792 Add class mw-parser-output to Parsoid's output
 ResolvedAnomieT167349 Tidy on WMF sites removes `<style>` tags
 ResolvedCKoerner_WMFT170863 Identify and coordinate deployment of initial deployment of Template Styles with select non-content Wikis
 ResolvedjhsobyT176082 Deploy TemplateStyles to svwiki
 ResolvedTgrT176268 Feature flag ("kill switch") for TemplateStyles
 DeclinedTgrT176269 Disallow <templatestyles> tags in non-Template namespaces
 ResolvedcorenT483 RfC: Allow styling in templates
 ResolvedAnomieT989 CSS validator survey and design work
 ResolvedTgrT188198 Enable TemplateStyles on ruwiki on 2018-04-10
 DeclinedNoneT187141 Deduplicate template styles in mobileviews API
 ResolvedssastryT187142 Deduplicate template styles in Parsoid
 ResolvedTgrT189022 Deploy TemplateStyles to zhwiki on 2018-07-19
 ResolvedTgrT190910 Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04
 ResolvedTgrT191612 Make the creation of CSS pages with TemplateStyles work more sensibly on the German Wikipedia
 ResolvedDeskanaT189834 [Epic] Deploy TemplateStyles to Wikivoyages
 ResolvedCKoerner_WMFT189835 Write announcement for TemplateStyles deployment to Wikivoyages
 ResolvedWhatamidoing-WMFT189836 Set deployment date for TemplateStyles on Wikivoyages, and publish announcement
 ResolvedTgrT189838 Create and deploy configuration change to enable TemplateStyles on Wikivoyages on 2018-03-28
 ResolvedTgrT191452 Deploy TemplateStyles on French Wikipedia on 2018-07-19
 ResolvedTgrT193786 [task] Configure TemplateStyles for nowiki
 ResolvedUrbanecmT197526 TemplateStyles in the Russian Wikiquote
 ResolvedTgrT197603 Deploy TemplateStyles to the English Wikipedia on 2018-07-19
 ResolvedTacsipacsiT198725 Deploy TemplateStyles on huwiktionary
 ResolvedTgrT199909 Deploy TemplateStyles everywhere on 2018-08-09
 ResolvedCKoerner_WMFT199982 Announce that TemplateStyles is being deployed everywhere with mass messages
 Resolved• JdlrobsonT195813 Hindi MainPage should use Template Styles (migrate all MediaWiki:Mobile.css and MediaWiki:MobileMainPage.css styles to templates)
 DeclinedNoneT203967 TemplateStyles should allow for "mobile-only" styles
 DeclinedNoneT198963 Add "Did you know..." and "On this day" sections from desktop main page to mobile main page
 OpenNoneT200880 Editor should flag mobile editing warnings
 ResolvedAmmarpadT241888 Disabling MFSpecialCaseMainPage on French Wiktionary
 Resolved• JdlrobsonT246401 Editors must review their main pages: End of life for wgMFSpecialCaseMainPage
 ResolvedKizuleT252065 Turn off main page special casing on itwiki
 ResolvedKizuleT252048 Disable $wgMFSpecialCaseMainPage for Scots Wikipedia
 DuplicateBrandonXLFT253268 Disable $wgMFSpecialCaseMainPage for English Wikipedia
 Resolved• JdlrobsonT254287 Final warning: Mobile main page special casing will be disabled July
ResolvedAmmarpadT254731 Turn off main page special casing on itwikisource and vecwikisource
 Resolved• JdlrobsonT257953 [Technical debt payoff] Drop MFSpecialCaseMainPage, from MobileFrontend
 Resolved• JdlrobsonT210808 Mark the MobileView API as deprecated
 Resolved• JdlrobsonT262580 Drop support for the deprecated mobileview "noimages" api parameter

Event Timeline

• Jdlrobson created this task.Nov 5 2018, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2018, 6:56 PM
• Jdlrobson added a subtask: T144085: Make MobileContext modular by creating the Blacklist service.Nov 5 2018, 6:57 PM
xSavitar awarded a token.Nov 5 2018, 6:57 PM
xSavitar added a subscriber: xSavitar.
• Jdlrobson added a subtask: T145219: [EPIC] Cleanup MobileFormatter and MobileViewAPI where they overlap.Nov 5 2018, 6:58 PM
• Jdlrobson added a subtask: T143189: [EPIC] Split MobileContext god object apart.
• Jdlrobson added a subscriber: pmiazga.Nov 5 2018, 7:13 PM

hey @pmiazga ! @D3r1ck01 has expressed a desire to help us improve our PHP code coverage as a way to learn more about unit testing. I've said I'd help provide guidance and code review. I'm guessing you would also be interested in doing this?

As a short term goal we'd seek 50% code coverage, then onwards to 70+.

• Jdlrobson added a project: Readers-Web-Backlog.Nov 5 2018, 7:42 PM
• Jdlrobson moved this task from Incoming to Epics/Goals on the Readers-Web-Backlog board.
xSavitar added a project: User-xSavitar.Nov 5 2018, 8:22 PM
xSavitar updated the task description. (Show Details)Nov 6 2018, 12:59 PM
pmiazga closed subtask T208797: PHPUnit: Cover all includes/MobileUI.php class methods as Resolved.Nov 7 2018, 8:57 PM
phuedx closed subtask T208987: PHPUnit: Cover all model/MobileCollection class methods as Resolved.Nov 15 2018, 5:30 PM
• Jdlrobson closed subtask T209713: PHPUnit: Cover all features/Feature class methods as Resolved.Nov 16 2018, 11:26 PM
xSavitar closed subtask T209218: PHPUnit: Cover all scenarios for WMFBaseDomainExtractor class as Resolved.Nov 22 2018, 8:02 PM
xSavitar mentioned this in T209933: [Starting Point] Increase PHPUnit coverage for MobileFrontend & MassMessage.Nov 23 2018, 3:41 PM
xSavitar removed a project: User-xSavitar.
• Jdlrobson closed subtask T209476: PHPUnit: Cover some model/MobilePage class methods as Resolved.Nov 23 2018, 5:34 PM
pmiazga closed subtask T210333: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests as Resolved.Nov 28 2018, 9:19 PM
pmiazga closed subtask T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.Dec 5 2018, 9:29 PM
• Jdlrobson added a comment.Dec 13 2018, 5:34 PM

@D3r1ck01 have you seen https://tools.wmflabs.org/coverme/?repo=Extension%3AMobileFrontend&type=all ? It gives a good idea of where your tests can have the most impact!

• Jdlrobson reopened subtask T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Open.Dec 13 2018, 5:46 PM
pmiazga awarded a token.Dec 13 2018, 5:58 PM
phuedx closed subtask T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests as Resolved.Dec 18 2018, 10:44 AM
phuedx closed subtask T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.Dec 18 2018, 11:01 AM
xSavitar reopened subtask T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Open.Jan 8 2019, 10:56 AM
• nray closed subtask T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.Jan 8 2019, 8:54 PM
• Jdlrobson triaged this task as Medium priority.Jan 11 2019, 12:54 AM
pmiazga closed subtask T212666: PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests as Resolved.Jan 25 2019, 4:47 PM
pmiazga closed subtask T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class as Resolved.Jan 25 2019, 8:20 PM
xSavitar added a subtask: T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.Jan 27 2019, 4:19 PM
• Jdlrobson closed subtask T145219: [EPIC] Cleanup MobileFormatter and MobileViewAPI where they overlap as Declined.Jul 21 2020, 3:24 PM
• Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 3:01 PM
• Jdlrobson moved this task from Team: web to Epics on the MobileFrontend board.Jul 24 2020, 3:11 PM
• Jdlrobson added a project: good first task.EditedJan 21 2021, 9:20 PM

We are currently at 33% so getting close to the 50% mark. Do we have tasks to take this over the finish line? The Amc and specials folder would be a good place to start.

https://doc.wikimedia.org/cover-extensions/MobileFrontend/

• Jdlrobson renamed this task from [Epic] Improve PHPUnit coverage in MobileFrontend to medium to [Epic] Improve PHPUnit coverage in MobileFrontend to 50%.Jan 21 2021, 9:20 PM
• Jdlrobson added a project: patch-welcome.
• Jdlrobson updated the task description. (Show Details)
• Jdlrobson closed subtask T144085: Make MobileContext modular by creating the Blacklist service as Declined.Apr 27 2021, 9:49 PM
• Jdlrobson updated the task description. (Show Details)Jul 15 2021, 10:54 PM
• Jdlrobson added a subtask: T261805: [spike, 4hrs] Review and possibly remove the unused SubHeadingTransform transform.
• Jdlrobson added a subtask: T186627: Remove the MobileView API.Jul 26 2021, 9:34 PM
• Jdlrobson moved this task from Epics/Goals to Needs Prioritization (Tech) on the Readers-Web-Backlog board.Aug 10 2021, 8:58 PM
• Jdlrobson edited projects, added Readers-Web-Backlog (Needs Prioritization (Tech)); removed Readers-Web-Backlog.
• Jdlrobson moved this task from Backlog to Simplify MobileFrontend on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.Aug 12 2021, 4:02 PM
• Jdlrobson closed subtask T261805: [spike, 4hrs] Review and possibly remove the unused SubHeadingTransform transform as Resolved.Apr 5 2022, 3:42 PM
• Jdlrobson updated the task description. (Show Details)Apr 6 2022, 10:44 PM
• Jdlrobson closed this task as Declined.Apr 28 2022, 11:17 PM

Currently at 31.28$ (28th April). I am not sure code coverage is a good goal right now for this repo, since most of our efforts are around removing code from the repository - in particular the specials folder (1258 lines of code with only 4.13% coverage) and API (305 / 478 lines of code coverage).

I think if we were interested in improving code coverage, I would recommend MobileContext.php (see T143189) and patches are very much welcome there.

• nray closed subtask T186627: Remove the MobileView API as Resolved.May 25 2022, 8:22 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL