Maniphest T208765

TemplateData module is loaded too often
Closed, ResolvedPublic
Actions

Description

"ext.templateDataGenerator.ui" is loaded whenever VE is loaded, and on every edit page, which is wasteful

Related Objects

Mentioned In: T208686: Missing icon 'menu' in VisualEditor

Event Timeline

Esanders created this task.Nov 5 2018, 7:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2018, 7:24 PM

Esanders mentioned this in T208686: Missing icon 'menu' in VisualEditor.Nov 5 2018, 7:53 PM

Change 473526 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/TemplateData@master] Move editPage->editTemplatePage, create minimal editTemplatePage

https://gerrit.wikimedia.org/r/473526

gerritbot added a project: Patch-For-Review.Nov 14 2018, 2:50 PM

Esanders claimed this task.Nov 14 2018, 2:50 PM

Esanders edited projects, added VisualEditor (Current work), Performance; removed VisualEditor.

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 473526 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Rename module editPage→editTemplatePage, create minimal new editPage module

https://gerrit.wikimedia.org/r/473526

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 24 2018, 8:00 PM

matmarex moved this task from Code review to Engineering QA on the VisualEditor (Current work) board.Nov 25 2018, 6:48 PM

Copying solution from gerrit: VisualEditorPluginModules loads whenever VE loads, so this fix creates a minimal loader page to check if we are in the template namespace before loading the rest of the TemplateData init code.

This appears to have been resolved. Is that correct?

Yes

Krinkle closed this task as Resolved.Jan 9 2019, 8:09 PM

TemplateData module is loaded too oftenClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

TemplateData module is loaded too often
Closed, ResolvedPublic
Actions