Page MenuHomePhabricator
Create Task
Maniphest T208766

Deprecate User::isWatched, isTempWatched, addWatch, and removeWatch
Closed, ResolvedPublic
Actions

Description

Currently, watchlist management is available via the User class. Factoring it out helps with resolving the circular dependency between User and Title.

Calls to User::isWatched, isTempWatched, addWatch, and removeWatch should be replaced with the respective calls to WatchedItemStore. Relevant permission checks must be retained, see T223165 for discussion as to how.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Deprecates Users isWatched, addWatch, and removeWatch methodsVedmaka Wakalakamediawiki/coremaster+322 -62
Replaces $user->addWatch call with WatchedItemStore addWatch service callVedmaka Wakalakamediawiki/extensions/Wikibasemaster+60 -5
Replaces $user->isWatched call with WatchedItemStore service isWatched callVedmaka Wakalakamediawiki/extensions/Echomaster+13 -1
Replaces User watch related calls that are going to be deprecatedVedmaka Wakalakamediawiki/extensions/Flowmaster+65 -7
Replaces $user->isWatching call with WatchedItemStore isWatching service callVedmaka Wakalakamediawiki/skins/Vectormaster+12 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Nov 5 2018, 7:27 PM
daniel updated the task description. (Show Details)
daniel added a project: MediaWiki-Watchlist.Nov 5 2018, 7:29 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 5 2018, 7:29 PM
daniel added a subtask: T208768: Create a PermissionManager service.Nov 5 2018, 8:02 PM
daniel removed a subtask: T208768: Create a PermissionManager service.
daniel added a subtask: T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.Nov 5 2018, 8:06 PM
• CCicalese_WMF moved this task from Inbox to Later on the Platform Team Legacy board.Nov 6 2018, 5:58 PM
• CCicalese_WMF edited projects, added: Platform Team Legacy (Later); removed: Platform Team Legacy.
daniel added a comment.Nov 8 2018, 12:54 PM

Since WatchedItemStore already exists, re-purposing this ticket to just call for isWatched, addWatch and removeWatch to be deprecated.

daniel renamed this task from Create a WatchlistManager service to Deprecate User::isWatched, addWatch, and removeWatch.Nov 8 2018, 12:57 PM
daniel updated the task description. (Show Details)
Catrope moved this task from Inbox to External on the Growth-Team board.Nov 13 2018, 8:48 AM
tosfos subscribed.Apr 1 2019, 2:13 PM
daniel edited projects, added: Platform Engineering (Decoupling (CDP2)); removed: Platform Engineering (Needs Cleaning - Code Health (TEC13)).Apr 1 2019, 2:13 PM
tosfos reassigned this task from daniel to Vedmaka.Apr 1 2019, 2:13 PM
gerritbot added a comment.Apr 15 2019, 3:55 PM

Change 504043 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/core@master] Deprecates Users isWatched, addWatch, and removeWatch methods usage

https://gerrit.wikimedia.org/r/504043

gerritbot added a project: Patch-For-Review.Apr 15 2019, 3:55 PM
gerritbot added a comment.Apr 27 2019, 7:38 PM

Change 506885 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/extensions/Flow@master] Replaces $user->removeWatch with WatchedItemStore service removeWatch call

https://gerrit.wikimedia.org/r/506885

gerritbot added a comment.Apr 27 2019, 9:09 PM

Change 506886 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/extensions/Wikibase@master] Replaces $user->addWatch call with WatchedItemStore addWatch service call

https://gerrit.wikimedia.org/r/506886

gerritbot added a comment.Apr 27 2019, 10:53 PM

Change 506888 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/extensions/Echo@master] Replaces $user->isWatched call with WatchedItemStore service isWatched call

https://gerrit.wikimedia.org/r/506888

gerritbot added a comment.Apr 27 2019, 11:08 PM

Change 506891 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/skins/Vector@master] Replaces $user->isWatching call with WatchedItemStore isWatching service call

https://gerrit.wikimedia.org/r/506891

daniel removed a subtask: T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.May 13 2019, 8:10 PM
daniel edited projects, added: Platform Team Workboards (Contractor - Doing); removed: Platform Team Legacy (Later).May 13 2019, 8:26 PM
daniel updated the task description. (Show Details)
• WDoranWMF moved this task from Contractor - Doing to S&F Workboard on the Platform Team Workboards board.Jul 5 2019, 4:53 PM
• WDoranWMF edited projects, added: Platform Team Workboards (S&F Workboard); removed: Platform Team Workboards (Contractor - Doing).
• WDoranWMF moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.
• WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:56 PM
• WDoranWMF edited projects, added: Core Platform Team Initiatives (Decoupling (CDP2)); removed: Platform Engineering (Decoupling (CDP2)).
• CCicalese_WMF removed a project: Platform Team Workboards (S&F Workboard).Sep 3 2019, 3:29 PM
daniel mentioned this in T208777: Factor notification-related methods out of User and Title, introduce WatchlistNotificationManager.Dec 4 2019, 10:20 AM
DannyS712 updated the task description. (Show Details)Dec 10 2019, 5:37 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 15 2020, 6:26 AM
gerritbot added a comment.Jan 21 2020, 12:05 PM

Change 506885 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replaces User watch related calls that are going to be deprecated

https://gerrit.wikimedia.org/r/506885

MusikAnimal renamed this task from Deprecate User::isWatched, addWatch, and removeWatch to Deprecate User::isWatched, isTempWatched, addWatch, and removeWatch.Jul 21 2020, 8:29 PM
MusikAnimal updated the task description. (Show Details)
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
gerritbot added a comment.Apr 29 2021, 2:47 PM

Change 506888 abandoned by Cicalese:

[mediawiki/extensions/Echo@master] Replaces $user->isWatched call with WatchedItemStore service isWatched call

Reason:

Made obsolete by Id380a5441e30041b6fb79f6ad1fc0506b6a770f9

https://gerrit.wikimedia.org/r/506888

gerritbot added a comment.Apr 29 2021, 2:49 PM

Change 506886 abandoned by Cicalese:

[mediawiki/extensions/Wikibase@master] Replaces $user->addWatch call with WatchedItemStore addWatch service call

Reason:

Made obsolete by Ib8bf129a8f31ca054a74a9ec07a1ca0f7ac3e68c

https://gerrit.wikimedia.org/r/506886

• CCicalese_WMF closed this task as Resolved.Apr 29 2021, 2:52 PM
• CCicalese_WMF closed subtask T223165: Implement access restrictions in WatchedItemStore as Resolved.Apr 29 2021, 2:57 PM
gerritbot added a comment.Sep 20 2023, 12:53 AM

Change 504043 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] Deprecates Users isWatched, addWatch, and removeWatch methods

Reason:

This was done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683442

https://gerrit.wikimedia.org/r/504043

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits