Maniphest T208775

Hard-deprecate Title::moveTo
Closed, ResolvedPublic
Actions

Description

Title::moveTo performs permission checks against the $wgUser global. This should be moved into the MovePage application logic class. Title::moveTo has been soft-deprecated since 1.25, it should now be hard-deprecated by having it call wfDeprecated( __METHOD__, '1.25' ).

As a second step, all callers to this method, in core and in extensions maintained by wmf, should be removed.

Rationale: Getting rid Title::moveTo would remove a dependency of Title on User, which is a step towards solving the circular dependency between these two classes.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hard-deprecate Title::moveTo and friends	mediawiki/core	master	+55 -51
	Hard-deprecate Title-moveTo	mediawiki/core	master	+16 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T208764 Remove cyclic dependency between Title and User classes
Resolved	BPirkle	T208775 Hard-deprecate Title::moveTo
Resolved	DannyS712	T221949 Remove uses of Title::moveTo
Duplicate	Art-Baltai	T243953 Remove Title::moveTo

Event Timeline

daniel created this task.Nov 5 2018, 7:54 PM

Aklapper added a project: Technical-Debt.Nov 6 2018, 12:07 AM

• CCicalese_WMF moved this task from Inbox to Later on the Platform Team Legacy board.Nov 6 2018, 5:58 PM

• CCicalese_WMF edited projects, added Platform Team Legacy (Later); removed Platform Team Legacy.

Izno moved this task from Unsorted to Deprecation process on the Technical-Debt board.Nov 11 2018, 3:38 PM

Izno edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.

daniel removed daniel as the assignee of this task.Apr 1 2019, 2:14 PM

daniel renamed this task from Deprecate Title::moveTo to Hard-deprecate Title::moveTo.Apr 1 2019, 7:27 PM

daniel updated the task description. (Show Details)

daniel edited projects, added Platform Engineering (Decoupling (CDP2)); removed Platform Engineering (Needs Cleaning - Code Health (TEC13)).Apr 1 2019, 7:38 PM

Change 504059 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Hard-deprecate Title-moveTo

https://gerrit.wikimedia.org/r/504059

gerritbot added a project: Patch-For-Review.Apr 15 2019, 4:29 PM

So moveTo() does a couple of extra things that MovePage doesn't. It calls spreadAnyEditBlock() if there's an error, and honors the suppressredirect permission. Why are these not done in MovePage proper? As it stands, it considerably complicates porting the existing users, which are fairly numerous.

In T208775#5112274, @Simetrical wrote:

So moveTo() does a couple of extra things that MovePage doesn't. It calls spreadAnyEditBlock() if there's an error, and honors the suppressredirect permission. Why are these not done in MovePage proper?

That's a very good question. I'd say it should be. I can't imagine why it should not.

Change 504338 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Hard-deprecate Title::moveTo and friends

https://gerrit.wikimedia.org/r/504338

Change 504059 abandoned by simetrical:
Hard-deprecate Title-moveTo

Reason:
I changed the Change-Id by mistake. For further work on this, please see: https://gerrit.wikimedia.org/r/504338

https://gerrit.wikimedia.org/r/504059

Lucas_Werkmeister_WMDE mentioned this in T221949: Remove uses of Title::moveTo.Apr 26 2019, 10:35 AM

• CCicalese_WMF reassigned this task from Simetrical to BPirkle.May 13 2019, 3:17 PM

• CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Later).

• CCicalese_WMF added a subscriber: Simetrical.

Krinkle moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.May 22 2019, 7:12 PM

Change 504338 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate Title::moveTo and friends