Page MenuHomePhabricator

make LogEventsList::showLogExtract() more versatile (patch)
Closed, ResolvedPublic

Description

Author: happy.melon.wiki

Description:
Against r50880, tweaks LogEventsList::showLogExtract()

Currently, this function can only be used to write a log extract directly to an OutputPage, invariably $wgOut. This is sub-optimal. This patch allows the $out parameter to alternatively be a pointer-to-string which is filled with the content. Fully B/C (AFAIK), return type unchanged. Works fine on my test wiki.


Version: 1.15.x
Severity: enhancement

Attached:

Details

Reference
bz18880

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:43 PM
bzimport set Reference to bz18880.
bzimport added a subscriber: Unknown Object (MLST).
demon added a comment.Jul 18 2009, 2:43 PM
  • Bug 19797 has been marked as a duplicate of this bug. ***

happy.melon.wiki wrote:

Oops, sorry for the duplicate, I was just running through a complete diff between my checkout and trunk, and didn't think I'd posted this patch yet. Updated patch against r53416 is attached to bug19797. Anyone feel like reviewing it? :D

happy.melon.wiki wrote:

Applied in r55693.