To date, the last three Minerva builds have had consecutive failures from tests using the Then I should see a toast notification step [1][2][3]
The tests are sometimes failing on the step "I should see a toast notification" which might be related to the fact that the toast displays asynchronously [4]. I cannot replicate on the production site which makes me think the issue is with the test itself. It also seems there was a previous attempt to address this in T170890, but it may not have fully resolved the issue.
Investigation needs to take place to uncover why this is still occurring and provide a solution to fix it.
[1] https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/lastCompletedBuild/testReport/(root)/Page%20actions%20menu%20when%20anonymous/I_cannot_edit_a_protected_page_when_anonymous/
[2] https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/lastCompletedBuild/testReport/(root)/Search/Clicking_on_a_watchstar_toggles_the_watchstar/
[3] https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/lastCompletedBuild/testReport/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/It_is_possible_to_edit/
[4] https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.notify.js
Developer notes
Things look like they are working well, it's just a problem with the test.
886c37e94f6 worthy of investigation.
Outcome
- This task is updated / a new bug is created documenting how to fix the problem.
- If the change is trivial and you can find a +2er feel free to fix it.