Page MenuHomePhabricator
Create Task
Maniphest T208898

[testwiki wmf3-regression] Watchlist: Misaligned dotdotdot in 'Saved filters'
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Etonkovidova
Nov 6 2018, 9:07 PM
Project Tags
Referenced Files
F27087632: Screen Shot 2018-11-06 at 7.11.32 PM.png
Nov 7 2018, 3:21 AM
F27087650: Screen Shot 2018-11-06 at 7.11.54 PM.png
Nov 7 2018, 3:21 AM
F27085888: Screen Shot 2018-11-06 at 2.48.04 PM.png
Nov 6 2018, 10:50 PM
F27084746: Screen Shot 2018-11-06 at 1.14.16 PM.png
Nov 6 2018, 9:19 PM
F27084732: Screen Shot 2018-11-06 at 1.16.59 PM.png
Nov 6 2018, 9:19 PM
F27084370: Screen Shot 2018-11-06 at 1.00.40 PM.png
Nov 6 2018, 9:19 PM
F27084275: Screen Shot 2018-11-06 at 12.57.16 PM.png
Nov 6 2018, 9:07 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
Jdforrester-WMF
Stashbot
Volker_E

Description

The issue is present in testwiki and betalabs.

  1. On testwiki go to Watchlist (or RecentChanges) with enabled filters.
  2. Click on Saved filters - the dotdotdot will be misalgned:

Screen Shot 2018-11-06 at 12.57.16 PM.png (460×555 px, 52 KB)

It could be corrected with (per @Volker_E investigation):

Screen Shot 2018-11-06 at 1.00.40 PM.png (394×577 px, 63 KB)

Another manifestation of misalignment:

Screen Shot 2018-11-06 at 1.16.59 PM.png (709×482 px, 88 KB)

vs

Screen Shot 2018-11-06 at 1.14.16 PM.png (736×495 px, 73 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Revert "RCFilters: Use `display: flex` for better responsiveness on narrow canvas"Jforrestermediawiki/corewmf/1.33.0-wmf.3+0 -49
Revert "RCFilters: Use `display: flex` for better responsiveness on narrow canvas"VolkerEmediawiki/coremaster+0 -49
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Nov 6 2018, 9:07 PM
Herald added a subscriber: Aklapper. · View Herald TranscriptNov 6 2018, 9:08 PM
Volker_E claimed this task.Nov 6 2018, 9:11 PM
Volker_E triaged this task as High priority.
Etonkovidova updated the task description. (Show Details)Nov 6 2018, 9:19 PM
Etonkovidova added a comment.Nov 6 2018, 10:50 PM

The third place to check after the fix: Special:Notifications:

Screen Shot 2018-11-06 at 2.48.04 PM.png (1,073×439 px, 83 KB)

gerritbot subscribed.Nov 7 2018, 12:05 AM

Change 472072 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Revert "RCFilters: Use display: flex for better responsiveness on narrow canvas"

https://gerrit.wikimedia.org/r/472072

gerritbot added a project: Patch-For-Review.Nov 7 2018, 12:05 AM
Volker_E mentioned this in T197065: New Filters for Edit Review: UI displays poorly when the window is narrow.Nov 7 2018, 12:09 AM
gerritbot added a comment.Nov 7 2018, 1:24 AM

Change 472072 merged by jenkins-bot:
[mediawiki/core@master] Revert "RCFilters: Use display: flex for better responsiveness on narrow canvas"

https://gerrit.wikimedia.org/r/472072

gerritbot added a comment.Nov 7 2018, 1:26 AM

Change 472083 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@wmf/1.33.0-wmf.3] Revert "RCFilters: Use display: flex for better responsiveness on narrow canvas"

https://gerrit.wikimedia.org/r/472083

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 2:00 AM
Etonkovidova added a comment.Nov 7 2018, 3:21 AM

The reported issue is fixed in betalabs.

There are two more places where stuff is misaligned - the notification flyout and Special:Notifications - or it's a different issue?

Screen Shot 2018-11-06 at 7.11.32 PM.png (566×378 px, 59 KB)

Screen Shot 2018-11-06 at 7.11.54 PM.png (1,081×401 px, 64 KB)

Aklapper renamed this task from [testwiki wmf3-regression] Watchlist: Misalgned dotdotdot in 'Saved filters' to [testwiki wmf3-regression] Watchlist: Misaligned dotdotdot in 'Saved filters' .Nov 7 2018, 3:56 AM
Aklapper added a project: MediaWiki-Recent-changes.
Herald added a project: Growth-Team. · View Herald TranscriptNov 7 2018, 3:56 AM
Jdforrester-WMF subscribed.Nov 7 2018, 3:58 AM
In T208898#4727330, @Etonkovidova wrote:

The reported issue is fixed in betalabs.

There are two more places where stuff is misaligned - the notification flyout and Special:Notifications - or it's a different issue?

Screen Shot 2018-11-06 at 7.11.32 PM.png (566×378 px, 59 KB)

That's T208930.

Screen Shot 2018-11-06 at 7.11.54 PM.png (1,081×401 px, 64 KB)

That's being worked on by @Volker_E right now.

Volker_E added a comment.EditedNov 7 2018, 3:58 AM

@Etonkovidova Thanks, truly helpful. Those are from a different task, T208930

gerritbot added a comment.Nov 7 2018, 4:29 PM

Change 472083 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.3] Revert "RCFilters: Use display: flex for better responsiveness on narrow canvas"

https://gerrit.wikimedia.org/r/472083

Stashbot subscribed.Nov 7 2018, 4:33 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-07T16:33:05Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.3/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.less: T208898 Hot-deploy to wmf.3 (duration: 00m 53s)

Jdforrester-WMF removed a project: Patch-For-Review.Nov 7 2018, 4:34 PM

Now live in production on wmf.3.

ReleaseTaggerBot edited projects, added: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06); removed: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 5:00 PM
Etonkovidova closed this task as Resolved.Nov 7 2018, 8:00 PM

Checked in testwiki wmf.3 - all seems to be correctly in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits