Page MenuHomePhabricator
Create Task
Maniphest T208918

wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Campsite task

As well as fixing this one stacktrace, all other "Checker"s should have their checkConstraint method checked for a similar issue.

Error Report

Error

Request ID: W@Ic1gpAIDwAAC08Gs4AAACW

message
BadMethodCallException: Call to a member function getStatements() on a non-object (null)
trace
#0 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(553): WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ContemporaryChecker->checkConstraint(WikibaseQuality\ConstraintReport\ConstraintCheck\Context\MainSnakContext, WikibaseQuality\ConstraintReport\Constraint)
#1 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(447): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->getCheckResultFor(WikibaseQuality\ConstraintReport\ConstraintCheck\Context\MainSnakContext, WikibaseQuality\ConstraintReport\Constraint)
#2 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(362): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkConstraintsForMainSnak(Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Statement\Statement, NULL, array)
#3 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(334): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkStatement(Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Statement\Statement, NULL, array)
#4 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(154): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkEveryStatement(Wikibase\DataModel\Entity\Item, NULL, array)
#5 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/Api/CheckingResultsSource.php(54): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkAgainstConstraintsOnEntityId(Wikibase\DataModel\Entity\ItemId, NULL, array, array)
#6 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(247): WikibaseQuality\ConstraintReport\Api\CheckingResultsSource->getResults(array, array, NULL, array)
#7 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(179): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getAndStoreResults(array, array, NULL, array)
#8 /srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/Api/CheckConstraints.php(181): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getResults(array, array, NULL, array)
#9 /srv/mediawiki/php-1.33.0-wmf.2/includes/api/ApiMain.php(1570): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#10 /srv/mediawiki/php-1.33.0-wmf.2/includes/api/ApiMain.php(531): ApiMain->executeAction()
#11 /srv/mediawiki/php-1.33.0-wmf.2/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#12 /srv/mediawiki/php-1.33.0-wmf.2/api.php(87): ApiMain->execute()

Impact

Certain user queries for wbcheckconstraints API consistently fail with a generic "Internal api error" exception.

Notes

WMF Logstash contains entries for this error description since at least 30 days (1.32.0-wmf.24 or earlier).

For example: https://www.wikidata.org/w/api.php?action=wbcheckconstraints&format=json&id=Q2518823.

See also: T128342

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Prevent exception in checker for deleted itemsmediawiki/extensions/WikibaseQualityConstraintsmaster+21 -4
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Nov 7 2018, 12:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 12:39 AM
Krinkle updated the task description. (Show Details)Nov 7 2018, 12:47 AM
Addshore triaged this task as Medium priority.Nov 7 2018, 9:45 AM
Addshore added a project: Wikidata-Campsite.
Addshore moved this task from incoming to consider for next sprint on the Wikidata board.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE subscribed.Nov 7 2018, 12:00 PM

The actual location of the error (PHP excludes it from the stack trace for reasons that escape me):

/srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/ContemporaryChecker.php:114

This corresponds to the $objectStatements assignment here:

		/** @var EntityId $subjectId */
		$subjectId = $context->getEntity()->getId();
		/** @var EntityId $objectId */
		$objectId = $snak->getDataValue()->getEntityId();
		/** @var Statement[] $subjectStatements */
		$subjectStatements = $context->getEntity()->getStatements()->toArray();
		/** @var Statement[] $objectStatements */
		$objectStatements = $this->entityLookup->getEntity( $objectId )->getStatements()->toArray();
		/** @var String[] $startPropertyIds */
		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
		/** @var String[] $endPropertyIds */
		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );

In this case, the object item has actually been deleted, which is not supposed to happen on Wikidata (items should only be deleted if they’re not used) but isn’t prevented on a technical level, so I guess ContemporaryChecker needs to guard against it. (If I recall correctly, several other checkers already include such guards.)

Addshore updated the task description. (Show Details)Nov 13 2018, 2:12 PM
Addshore set the point value for this task to 3.
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from consider for next sprint to in progress on the Wikidata board.Nov 13 2018, 3:32 PM
Michael claimed this task.Nov 14 2018, 12:00 PM
Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot subscribed.Nov 14 2018, 4:02 PM

Change 473549 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Prevent exception in checker for deleted items

https://gerrit.wikimedia.org/r/473549

gerritbot added a project: Patch-For-Review.Nov 14 2018, 4:02 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 15 2018, 8:48 AM

ContemporaryChecker had the only call for \Wikibase\DataModel\Services\Lookup\EntityLookup::getEntity that wasn't guarded against a null result.

gerritbot added a comment.Nov 15 2018, 10:17 AM

Change 473549 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Prevent exception in checker for deleted items

https://gerrit.wikimedia.org/r/473549

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 15 2018, 10:28 AM

Not sure how much verification this needs – do we want to wait until the fix is deployed (two weeks), and then see if the logstash errors disappear?

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 15 2018, 11:01 AM
Addshore subscribed.Nov 15 2018, 1:21 PM
In T208918#4749525, @Lucas_Werkmeister_WMDE wrote:

Not sure how much verification this needs – do we want to wait until the fix is deployed (two weeks), and then see if the logstash errors disappear?

Yup, I think that is a good idea :)

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 3 2018, 2:55 PM
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

No more errors in Logstash since the 29th, when Wikidata went back on wmf.6 (after some unrelated issues). Checking constraints on Q2518823 works now (and the item still features a value for a deleted item). Looks fixed to me.

Restricted Application added a project: User-Michael. · View Herald TranscriptDec 3 2018, 2:55 PM
Michael moved this task from 🗃️ Incoming to ✅ my work done on the User-Michael board.Dec 3 2018, 2:57 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits