Page MenuHomePhabricator

Deprecated Article::updateArticle still used in core
Closed, ResolvedPublic

Description

Deprecated Article::updateArticle still used in core (also in some svn extensions).

includes/EditPage.php: if ( $this->mArticle->updateArticle( $text, $this->summary, $this->minoredit,
includes/Article.php: function updateArticle( $text, $summary, $minor, $watchthis, $forceBot = false, $sectionanchor = '' ) {

maintenance/cleanupSpam.php: $article->updateArticle( '', wfMsg( 'spam_blanking', $domain ),
maintenance/cleanupSpam.php: $article->updateArticle( $rev->getText(), wfMsg( 'spam_reverting', $domain ), false, false );

extensions/SpamDiffTool/SpamDiffTool.php: $a->updateArticle($text, wfMsg('spamdifftool_summary'), false, $watch) ;
extensions/SpamDiffTool/SpamDiffTool.php: $wgOut->redirect($wgScript . "?" . urldecode($returnto) ); // clear the redirect set by updateArticle
extensions/SpamBlacklist/cleanup.php: $article->updateArticle( '', "All revisions matched the spam blacklist ($match), blanking",
extensions/SpamBlacklist/cleanup.php: $article->updateArticle( $rev->getText(), "Cleaning up links to $match", false, false );
extensions/Postcomment/SpecialPostcomment.php: $article->updateArticle($text, "", true, $watch);
extensions/TalkHere/TalkHereArticle.php: else if ($name == 'updateArticle' && $res) {
extensions/DynamicPageList/DynamicPageList2.php: $message = $this->updateArticleByRule($title,$text,$updateRules);
extensions/DynamicPageList/DynamicPageList2.php: function updateArticleByRule($title,$text,$rulesText) {
extensions/DynamicPageList/DynamicPageList2.php: if ($exec) $articleX->updateArticle($text, $summary, false, $titleX->userIsWatching());


Version: unspecified
Severity: normal

Details

Reference
bz18892

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:36 PM
bzimport set Reference to bz18892.
bzimport added a subscriber: Unknown Object (MLST).

happy.melon.wiki wrote:

AFAIK. In EditPage.php at least.

robert wrote:

Resolved in r69293. No further occurrences found in phase3 or extensions.

robert wrote:

Due to a mistake in my search command I missed one occurrence in the DPL extension, however this bug remains resolved as there are no occurrences in core.

There was still one occurrence in EditPage.php that I modified in r80402.