Page MenuHomePhabricator

Label lang error in map
Open, NormalPublic

Event Timeline

Shizhao created this task.Nov 7 2018, 2:58 AM
Restricted Application added subscribers: Cosine02, Aklapper. · View Herald TranscriptNov 7 2018, 2:58 AM
Shizhao updated the task description. (Show Details)Nov 7 2018, 3:00 AM
Shizhao updated the task description. (Show Details)Nov 7 2018, 3:03 AM
Pikne added a subscriber: Pikne.EditedNov 21 2018, 8:41 AM

Seems to be the same as T195318. 'zh-cn' falls back to 'zh-hans' which in turn doesn't fall back to anything. Since South Korea label node (249399362) doesn't have 'name:<lang>' key for neither code then 'name' key value (Korean name) or maybe no name label at all should be used, but instead name in some unexpected language is used, in this case Romansh name ('name:rm' key value).

If find this code which is supposed to do some latinization, but it doesn't seem to work as described. Language using non-Latin script seems to be latinized here. Whilist for Latin-script language 'zh_pinyin' name variants are not shown (e.g. Finnish here), and for Szeged (task referred above) local name ('name' key) is already Latin-script and it shouldn't be necessary to pick up specific 'Latn' suffix.

In addition, as long as internationalization relies on OSM tags then you might want to rework fallbacks so that they wouldn't fall back to codes that some OSM contributors are dedicated to avoid and remove as 'Wikipedia inventions'. So maybe 'zh-hans' could fall back to 'zh', not the other way around.

Mholloway triaged this task as Normal priority.Nov 27 2018, 4:08 PM
Pikne added a subscriber: Mooeypoo.EditedMar 18 2019, 8:53 AM

Update: it seems that now after patch by @Mooeypoo has been deployed it no longer displays "South Korea" in Romansh (rm) for "zh-cn". Now it displays Korean name as "zh-cn" doesn't fall back to "zh". "Japan" however is still latinized as "Nippon" (ja_rm) for "zh-cn". Also, "ko-Latn" value is used to latinize "zh-cn", e.g. see "Namp'o" here.

May I suggest a simple fix: if latinization is too complicated and it's hard to get it work right, so that it wouldn't do more harm than good, then for a start, let's omit it in language picker.

Haros added a subscriber: Haros.Mar 18 2019, 10:43 AM
Shizhao added a comment.EditedMar 19 2019, 3:42 AM
在T208927#5031594中,@Pikne写道:

Now it displays Korean name as "zh-cn" doesn't fall back to "zh". "Japan" however is still latinized as "Nippon" (ja_rm) for "zh-cn". Also, "ko-Latn" value is used to latinize "zh-cn", e.g. see "Namp'o" here.

In zoom level 6: Korean displays as “Corea dal sid”, Japan displays as "Nippon"(?), China displays as "China"
In zoom level 4, 5: Korean displays as a Korean language, Japan displays as "Giapun", China displays as "China"
In zoom level 3: Korean displays as a Korean language, Japan displays as "Giapun", China displays as Chinese Hanzi "中国"

Pikne added a comment.Mar 19 2019, 6:35 AM

I don't know, maybe some tiles for some zoom levels are cached somewhere. "China", "Corea dal sid" and "Giapun" are Romansh name variants that should no longer appear on new tiles. Other issues seem to remain, though.