Page MenuHomePhabricator
Create Task
Maniphest T208930

NotificationItemWidget is breaking to next line in Notifications
Closed, ResolvedPublic
Actions

Description

Another breakage from T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons and its a8ef5fe765c1.

image.png (508×197 px, 26 KB)
and
image.png (696×116 px, 12 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix two layout regressions from OOUI ButtonSelectWidget changeJforrestermediawiki/extensions/Echowmf/1.33.0-wmf.3+9 -0
Fix two layout regressions from OOUI ButtonSelectWidget changeVolkerEmediawiki/extensions/Echomaster+9 -0
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Nov 7 2018, 3:30 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 7 2018, 3:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Nov 7 2018, 3:43 AM

Change 472092 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Fix regression from OOUI ButtonSelectWidget change

https://gerrit.wikimedia.org/r/472092

gerritbot added a project: Patch-For-Review.Nov 7 2018, 3:43 AM
Jdforrester-WMF mentioned this in T208898: [testwiki wmf3-regression] Watchlist: Misaligned dotdotdot in 'Saved filters' .Nov 7 2018, 3:58 AM
Volker_E renamed this task from NotificationItemWidget is breaking to next line in Notification popup to NotificationItemWidget is breaking to next line in Notifications.Nov 7 2018, 3:58 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Nov 7 2018, 4:24 AM

Change 472092 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix two layout regressions from OOUI ButtonSelectWidget change

https://gerrit.wikimedia.org/r/472092

gerritbot added a comment.Nov 7 2018, 4:25 AM

Change 472093 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/extensions/Echo@wmf/1.33.0-wmf.3] Fix two layout regressions from OOUI ButtonSelectWidget change

https://gerrit.wikimedia.org/r/472093

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 5:00 AM
• matmarex mentioned this in T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons.Nov 7 2018, 10:56 AM
gerritbot added a comment.Nov 7 2018, 4:17 PM

Change 472093 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.33.0-wmf.3] Fix two layout regressions from OOUI ButtonSelectWidget change

https://gerrit.wikimedia.org/r/472093

Stashbot subscribed.Nov 7 2018, 4:22 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-07T16:21:55Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/Echo/modules/styles: Hot-deploy T208930 to wmf.3 (duration: 00m 54s)

Jdforrester-WMF removed a project: Patch-For-Review.Nov 7 2018, 4:22 PM

Now live in production on wmf.3.

ReleaseTaggerBot edited projects, added: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06); removed: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 5:00 PM
• matmarex closed this task as Resolved.Nov 7 2018, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits