Maniphest T208965

Partially blocked admins should be able to access Special:Block
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• TBolliger
	Nov 7 2018, 5:35 PM

Description

If an admin is partially blocked they cannot access Special:Block to modify their own block — or to block another user. However, they can access Special:Unblock and unblock themselves.

Screen Shot 2018-11-07 at 9.31.04 AM.png (895×1 px, 287 KB)

Acceptance criteria

If an admin is partially blocked, allow them to fully use Special:Block on any user/IP/range.

Details

	Subject	Repo	Branch	Lines +/-
	Allow partially blocked admins to block users	mediawiki/core	master	+11 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T204903 Epic ⚡️ unprioritized Partial Blocks features
Resolved	Ammarpad	T208965 Partially blocked admins should be able to access Special:Block
Resolved	dbarratt	T209097 FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked
Resolved	dmaza	T203821 After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org

Event Timeline

• TBolliger created this task.Nov 7 2018, 5:35 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 7 2018, 5:35 PM

If we want to make it so a PB'd user cannot modify their partial block we should open another ticket.

• TBolliger triaged this task as Low priority.Nov 7 2018, 5:45 PM

• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.

@Trevor, agree that this ticket should not do the big change of stopping admin from unblocking their own account. And also the PB can not modify belong in another ticket, too.

This ticket is only for allowing admin who have a partial block to be able to do partially and full block for other users.

dbarratt added a subtask: T209097: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked.Nov 8 2018, 7:55 PM

• TBolliger moved this task from Product/Tech backlog to Snackbox on the Anti-Harassment board.Nov 16 2018, 3:44 PM

• TBolliger merged a task: T208513: Admins should be able to block users while partially-blocked.

• TBolliger added a subscriber: jrbs.

• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment.Nov 19 2018, 9:27 PM

• TBolliger moved this task from Ready to Archive of tickets closed outside this sprint, but need someplace to go on the Anti-Harassment (AHT Sprint 33) board.

• TBolliger edited projects, added Anti-Harassment; removed Anti-Harassment (AHT Sprint 33).Nov 19 2018, 9:35 PM

• TBolliger moved this task from Snackbox to Triage/To be Estimated on the Anti-Harassment board.Nov 26 2018, 6:27 PM

• TBolliger updated the task description. (Show Details)Jan 14 2019, 6:21 PM

• TBolliger mentioned this in T214424: Admin who performs partial block cannot re-block the blocked user or other users.Jan 22 2019, 7:34 PM

Confirmed still incorrect behavior on test wiki today

May be solved by T209097

• TBolliger moved this task from Triage/To be Estimated to Product/Tech backlog on the Anti-Harassment board.Jan 23 2019, 7:35 PM

• TBolliger lowered the priority of this task from Low to Lowest.Jan 30 2019, 10:12 PM

• TBolliger added a parent task: T204903: Epic ⚡️ unprioritized Partial Blocks features.

• TBolliger removed a project: Anti-Harassment.

In T208965#4903469, @TBolliger wrote:

May be solved by T209097

This is bug still appears to be present (tested today on beta MediaWiki 1.33.0-alpha (3821a2b) 11:26, 1 April 2019).

dbarratt closed subtask T209097: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked as Resolved.Apr 4 2019, 7:26 PM

Tchanders mentioned this in T220642: Only show the feedback link on Special:Block to users who can access the page.Jun 12 2019, 2:00 PM

Izno mentioned this in T242633: Partial blocks prevent blocking.Jan 13 2020, 4:48 PM

SQL merged a task: T242633: Partial blocks prevent blocking.Jan 13 2020, 4:57 PM

SQL added subscribers: Izno, TheSandDoctor, Amorymeltzer.

SQL subscribed.

I have removed the reference to "including themselves" per the other work to remove self-unblocks generally.

Xaosflux subscribed.Jan 13 2020, 8:45 PM

Mz7 subscribed.Jan 13 2020, 9:29 PM

Xaosflux mentioned this in T244065: Partially blocked users should not be blocked from using Special:Block.Feb 1 2020, 4:25 PM

Xaosflux merged a task: T244065: Partially blocked users should not be blocked from using Special:Block.

Notes from duplicate:

Currently, if a user that has access to block is partially blocked in any way, including with an empty block (T208645) - they are blocked from using Special:Block.

This behavior should only apply to users that are site-blocked, or that in the future could have an action block (i.e. if T242541 is adopted) against blocking.

Regarding the unblockself - this is being stopped at least on WMF wikis.

IKhitron subscribed.Feb 2 2020, 3:32 PM

Change 584911 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Allow partially blocked admins to block users

https://gerrit.wikimedia.org/r/584911

gerritbot added a project: Patch-For-Review.Mar 31 2020, 11:50 AM

Ammarpad claimed this task.Apr 1 2020, 9:01 PM

Change 584911 merged by jenkins-bot:
[mediawiki/core@master] Allow partially blocked admins to block users

https://gerrit.wikimedia.org/r/584911

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 2 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2020, 3:11 PM

In T208965#5074206, @dom_walden wrote:

This is bug still appears to be present (tested today on beta MediaWiki 1.33.0-alpha (3821a2b) 11:26, 1 April 2019).

@dom_walden, this is now fixed in d8786ebf7d5e.

Ammarpad closed this task as Resolved.Apr 11 2020, 7:45 AM

• Niharika added a project: MediaWiki-Blocks.Apr 13 2020, 9:19 PM

JJMC89 moved this task from Backlog to Partial blocks on the MediaWiki-Blocks board.Apr 25 2020, 6:06 PM

JJMC89 removed a project: MediaWiki-User-management.Apr 25 2020, 6:44 PM

Tchanders mentioned this in T242541: Allow partial blocks against specified actions.Jun 10 2020, 3:39 PM