Page MenuHomePhabricator
Create Task
Maniphest T208968

Partially blocked users should be able to patrol edits for other pages
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Patrolling is a review process that allows users holding the patrol permission to mark edits from new accounts as patrolled, signaling to other users "This edit is good, no need to review".

On Test Wikipedia only Bots and Admins have the patrol permission, so I tested on my own account User:TBolliger_(WMF)

Expected behavior

  • A partially blocked user with patrol permissions...
    • 1. should not be able to patrol changes on pages defined in their partial block
    • 2. should be able to patrol edits on pages not within the parameters of their partial block

Use case 1 — success

If a user is PB'd from a page they cannot patrol edits on that page

Use case 2 — failure

If a user is not PB'd from a page, they are prohibited from marking any edit on any page as patrolled. Please fix this defect.

Related Objects
Search...

Event Timeline

• TBolliger created this task.Nov 7 2018, 5:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 5:50 PM
• TBolliger triaged this task as Low priority.Nov 7 2018, 5:51 PM
• TBolliger added a project: Anti-Harassment.
• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptNov 7 2018, 5:51 PM
• TBolliger moved this task from Untriaged to Product backlog on the Anti-Harassment board.Nov 7 2018, 5:51 PM
• TBolliger raised the priority of this task from Low to Medium.Nov 8 2018, 7:48 PM
• TBolliger moved this task from Product backlog to AHT Sprint 33 on the Anti-Harassment board.
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment.

On Italian Wikipedia, Patrol is available for confirmed users: https://it.wikipedia.org/wiki/Speciale:ElencoPermessiGruppi

• TBolliger mentioned this in T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 8 2018, 7:49 PM
dbarratt added a subtask: T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock.Nov 8 2018, 8:13 PM
• TBolliger set the point value for this task to 1.Nov 8 2018, 8:14 PM
Oshwah added a subscriber: Oshwah.Nov 8 2018, 9:04 PM
dbarratt changed the task status from Open to Stalled.Nov 8 2018, 10:24 PM
• TBolliger added a comment.Nov 9 2018, 6:52 PM

This is not fixed via T208862 on https://thegoodplace.wmflabs.org/wiki/Main_Page

dbarratt edited subtasks, added: T209284: Action::checkCanExecute should only block an Action if the user is sitewide blocked; removed: T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock.Nov 12 2018, 3:08 PM
dbarratt added a subscriber: dbarratt.

MarkpatrolledAction extends FormAction which extends Action

requiresUnblock() returns the default value, true

dbarratt added a parent task: T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 12 2018, 3:15 PM
dbarratt assigned this task to • TBolliger.Nov 15 2018, 5:17 PM
dbarratt moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 33) board.
• TBolliger closed this task as Resolved.Nov 15 2018, 5:48 PM
• TBolliger moved this task from Review to Done on the Anti-Harassment (AHT Sprint 33) board.

Works as expected on thegoodplace test wiki, as of yesterday.

• TBolliger added a subtask: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 19 2018, 10:01 PM
dbarratt closed subtask T209284: Action::checkCanExecute should only block an Action if the user is sitewide blocked as Resolved.Nov 19 2018, 11:33 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL