Page MenuHomePhabricator
Create Task
Maniphest T208970

certcentral wrongly handles acme.errors.ValidationError exception
Closed, ResolvedPublic
Actions

Description

certcentral currently interprets the exception acme.errors.ValidationError as challenges have been marked as "invalid". But python3-acme code raises that exception every time that a challenge status is not valid.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
debian: Add release 0.6 to changelogVgutierrezoperations/software/certcentraldebian+8 -0
Release 0.6Vgutierrezoperations/software/certcentraldebian+1 -1
certcentral: Stop using acme.client.poll_and_finalize()Vgutierrezoperations/software/certcentraldebian+150 -31
Release 0.6Vgutierrezoperations/software/certcentralmaster+1 -1
certcentral: Stop using acme.client.poll_and_finalize()Vgutierrezoperations/software/certcentralmaster+150 -31
Customize query in gerrit

Related Objects

Event Timeline

Vgutierrez created this task.Nov 7 2018, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 5:53 PM
Vgutierrez renamed this task from certcentral wrongly interprets acme.errors.ValidationError exception to certcentral handles interprets acme.errors.ValidationError exception.Nov 7 2018, 5:54 PM
Vgutierrez renamed this task from certcentral handles interprets acme.errors.ValidationError exception to certcentral wrongly handles acme.errors.ValidationError exception.
Vgutierrez triaged this task as Medium priority.
gerritbot subscribed.Nov 8 2018, 4:00 PM

Change 472487 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@master] certcentral: Stop using acme.client.poll_and_finalize()

https://gerrit.wikimedia.org/r/472487

gerritbot added a project: Patch-For-Review.Nov 8 2018, 4:00 PM
Vgutierrez mentioned this in rOSCC2402b587c2ef: certcentral: Stop using acme.client.poll_and_finalize().Nov 8 2018, 4:01 PM
Vgutierrez mentioned this in rOSCCd8ecb5c6b2d9: certcentral: Stop using acme.client.poll_and_finalize().Nov 8 2018, 4:08 PM
Vgutierrez mentioned this in rOSCC6169b5facae5: certcentral: Stop using acme.client.poll_and_finalize().Nov 8 2018, 5:40 PM
Vgutierrez mentioned this in rOSCC8969ef7d32ed: certcentral: Stop using acme.client.poll_and_finalize().Nov 8 2018, 6:50 PM
gerritbot added a comment.Nov 8 2018, 7:40 PM

Change 472487 merged by jenkins-bot:
[operations/software/certcentral@master] certcentral: Stop using acme.client.poll_and_finalize()

https://gerrit.wikimedia.org/r/472487

gerritbot added a comment.Nov 9 2018, 8:43 AM

Change 472621 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@master] Release 0.6

https://gerrit.wikimedia.org/r/472621

Vgutierrez mentioned this in rOSCCd1583469c43c: Release 0.6.Nov 9 2018, 8:46 AM
gerritbot added a comment.Nov 9 2018, 8:47 AM

Change 472621 merged by Vgutierrez:
[operations/software/certcentral@master] Release 0.6

https://gerrit.wikimedia.org/r/472621

gerritbot added a comment.Nov 9 2018, 8:50 AM

Change 472624 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@debian] certcentral: Stop using acme.client.poll_and_finalize()

https://gerrit.wikimedia.org/r/472624

gerritbot added a comment.Nov 9 2018, 8:50 AM

Change 472625 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@debian] Release 0.6

https://gerrit.wikimedia.org/r/472625

Vgutierrez mentioned this in rOSCC058861ec08f1: certcentral: Stop using acme.client.poll_and_finalize().Nov 9 2018, 8:52 AM
Vgutierrez mentioned this in rOSCC69fff94a8845: Release 0.6.
gerritbot added a comment.Nov 9 2018, 8:53 AM

Change 472624 merged by Vgutierrez:
[operations/software/certcentral@debian] certcentral: Stop using acme.client.poll_and_finalize()

https://gerrit.wikimedia.org/r/472624

gerritbot added a comment.Nov 9 2018, 8:53 AM

Change 472625 merged by Vgutierrez:
[operations/software/certcentral@debian] Release 0.6

https://gerrit.wikimedia.org/r/472625

gerritbot added a comment.Nov 9 2018, 8:57 AM

Change 472626 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@debian] debian: Add release 0.6 to changelog

https://gerrit.wikimedia.org/r/472626

gerritbot added a comment.Nov 9 2018, 8:59 AM

Change 472626 merged by Vgutierrez:
[operations/software/certcentral@debian] debian: Add release 0.6 to changelog

https://gerrit.wikimedia.org/r/472626

Vgutierrez mentioned this in rOSCC39e0a2e35866: debian: Add release 0.6 to changelog.Nov 9 2018, 8:59 AM
Stashbot mentioned this in T208859: certcentral: keep track of orders and authorizations IDs when issuing certificates.Nov 9 2018, 10:50 AM
Stashbot mentioned this in T208948: certcentral "wrongly" assumes that a new order always implies fulfilling new challenges.
Stashbot mentioned this in T208967: Avoid using acme.client poll_and_finalize() method.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-11-09T10:50:54Z] <vgutierrez> uploaded certcentral 0.6 to apt.wikimedia.org (stretch) - T208859 T208948 T208967 T208970

Vgutierrez closed this task as Resolved.Nov 20 2018, 4:57 PM
Vgutierrez removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits