The class in model/MobileCollection.php file has no code coverage. Tests should be written to fix this.
Acceptance criteria
- Write unit tests to cover all methods in /models/MobileCollection.php.
- Code coverage report has gone up.
The class in model/MobileCollection.php file has no code coverage. Tests should be written to fix this.
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Declined | None | T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50% | |||
Resolved | xSavitar | T208987 PHPUnit: Cover all model/MobileCollection class methods |
Change 472341 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add MobileCollectionTest for MobileCollection::class
Change 472427 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add MobilePageTest to test MobilePage::class
Change 472341 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add MobileCollectionTest for MobileCollection::class
Change 473454 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Fix $expected and $actual values in MobileCollectionTest
I've separated this task and here is the other half: T209476. Once the patches here are merged, this can be resolved. Would want to tackle these tasks in smaller bits :)
Change 473454 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix $expected and $actual values in MobileCollectionTest
https://gerrit.wikimedia.org/r/472427 i still open and has a -1? Should that be abandoned or is that still being done?
+-----------------------------+-------+--------+ | Filename | Old % | New % | +-----------------------------+-------+--------+ | models/MobileCollection.php | 0 | 100.00 | +-----------------------------+-------+--------+
🎉🎉🎉
Change 472427 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add MobilePageTest to test MobilePage::class