Maniphest T208987

PHPUnit: Cover all model/MobileCollection class methods
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	xSavitar
	Nov 7 2018, 7:26 PM

Description

The class in model/MobileCollection.php file has no code coverage. Tests should be written to fix this.

Acceptance criteria

Write unit tests to cover all methods in /models/MobileCollection.php.
Code coverage report has gone up.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+10 -10	Fix $expected and $actual values in MobileCollectionTest
	mediawiki/extensions/MobileFrontend	master	+66 -1	Add MobileCollectionTest for MobileCollection::class

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
		Resolved		xSavitar	T208987 PHPUnit: Cover all model/MobileCollection class methods

Event Timeline

xSavitar created this task.Nov 7 2018, 7:26 PM

Jdlrobson awarded a token.Nov 7 2018, 7:32 PM

Jdlrobson triaged this task as Medium priority.Nov 7 2018, 9:45 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.

Change 472341 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add MobileCollectionTest for MobileCollection::class

https://gerrit.wikimedia.org/r/472341

gerritbot added a project: Patch-For-Review.Nov 7 2018, 10:22 PM

xSavitar claimed this task.Nov 7 2018, 10:24 PM

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

Change 472427 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add MobilePageTest to test MobilePage::class

https://gerrit.wikimedia.org/r/472427

Jdlrobson edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.Nov 9 2018, 5:29 PM

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Change 472341 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add MobileCollectionTest for MobileCollection::class

https://gerrit.wikimedia.org/r/472341

xSavitar updated the task description. (Show Details)Nov 9 2018, 9:28 PM

Jdlrobson moved this task from Needs Code Review to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 9 2018, 9:30 PM

xSavitar updated the task description. (Show Details)Nov 9 2018, 9:32 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 9 2018, 10:00 PM

Change 473454 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Fix $expected and $actual values in MobileCollectionTest

https://gerrit.wikimedia.org/r/473454

I've separated this task and here is the other half: T209476. Once the patches here are merged, this can be resolved. Would want to tackle these tasks in smaller bits :)

xSavitar updated the task description. (Show Details)Nov 14 2018, 12:01 PM

xSavitar moved this task from Doing [WIP] to Completed (To be Resolved) on the User-xSavitar board.Nov 14 2018, 12:14 PM

Change 473454 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix $expected and $actual values in MobileCollectionTest

https://gerrit.wikimedia.org/r/473454

@Jdlrobson, so this is all good! Ready to sign-off?

https://gerrit.wikimedia.org/r/472427 i still open and has a -1? Should that be abandoned or is that still being done?

I separated the task, so that now is tracked here: T209476. See: T208987#4745948.

Jdlrobson removed a project: Epic.Nov 14 2018, 6:26 PM

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 14 2018, 6:59 PM

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 14 2018, 7:00 PM

+-----------------------------+-------+--------+
| Filename                    | Old % | New %  |
+-----------------------------+-------+--------+
| models/MobileCollection.php | 0     | 100.00 |
+-----------------------------+-------+--------+

🎉🎉🎉

Change 472427 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add MobilePageTest to test MobilePage::class

https://gerrit.wikimedia.org/r/472427

Ops, wrong ticket reference :(

xSavitar awarded a token.Dec 5 2018, 9:37 PM

PHPUnit: Cover all model/MobileCollection class methodsClosed, ResolvedPublicActions